Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement compatibility with the new automatic multicast discovery in plugin broker #13272

Closed
ibuziuk opened this issue May 2, 2019 · 7 comments
Assignees
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.

Comments

@ibuziuk
Copy link
Member

ibuziuk commented May 2, 2019

Placeholder for the issue described in comment #12395 (comment)

@ibuziuk ibuziuk added kind/bug Outline of a bug - must adhere to the bug report template. kind/task Internal things, technical debt, and to-do tasks to be performed. target/che7GA and removed kind/bug Outline of a bug - must adhere to the bug report template. labels May 2, 2019
@ibuziuk
Copy link
Member Author

ibuziuk commented May 2, 2019

@davidfestal could you please provide the description to the issue to identify the scope and share it with the languages team?

@davidfestal
Copy link
Contributor

It seems the link to the comment had been lost in the issue description. let me add it back.

And quote @benoitf comment here as well for @tsmaeder :

there is now automatic multicast discovery and auto-port assignment for sidecar
so you should just copy plug-ins into /my-plug-ins folder and set THEIA_PLUGINS=local-dir:///my-plug-ins in each sidecar. Main instance of theia will detect endpoint and endpoint will take some random ports automatically

So in the plugin broker, there is no need to manage ports anymore. Only one environment variable should be added to each plugin container with the location where plugin files should be copied (local-dir:///my-plug-ins).
This should simplify the plugin broker very much.

@tsmaeder
Copy link
Contributor

tsmaeder commented May 3, 2019

This should simplify the plugin broker very much.

I understand this, but if it means self hosting gets broken, I am against using broadcast discovery. I think we should always use a "scope" if we're using auto-discovery.

@davidfestal
Copy link
Contributor

@benoitf any idea about whether it might break self-hosting ?

@tsmaeder
Copy link
Contributor

tsmaeder commented May 3, 2019

I don't really understand why this is a Che 7 GA issue. The current way of doing things works, no?

@amisevsk
Copy link
Contributor

@davidfestal Can this issue be closed?

@ibuziuk
Copy link
Member Author

ibuziuk commented Jun 3, 2019

Closing as done

@ibuziuk ibuziuk closed this as completed Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

No branches or pull requests

4 participants