Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview URL not displayed while accessible #13357

Closed
slemeur opened this issue May 17, 2019 · 9 comments · Fixed by eclipse-che/che-theia#318
Closed

Preview URL not displayed while accessible #13357

slemeur opened this issue May 17, 2019 · 9 comments · Fixed by eclipse-che/che-theia#318
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code.
Milestone

Comments

@slemeur
Copy link
Contributor

slemeur commented May 17, 2019

Description

While I've been able to access the previewURL and it is accessible. The preview panel is not rendering the URL properly.
See attached screenshot:

Capture d’écran 2019-05-17 à 11 57 35

Reproduction Steps

  1. Java-Maven Stack + vertx-http-booster
  2. run task "run"

OS and version:

Diagnostics:

@slemeur slemeur added kind/bug Outline of a bug - must adhere to the bug report template. team/ide labels May 17, 2019
@akurinnoy akurinnoy self-assigned this Jun 19, 2019
@akurinnoy
Copy link
Contributor

hello @slemeur
I'm confused a bit with the description.
Could you please elaborate on it? Where is the bug? What is expected behavior?

@slemeur
Copy link
Contributor Author

slemeur commented Jun 20, 2019

Check in the previewURLs panel.
It seems that ${server.8080}/tcp which is not compute properly.

@akurinnoy
Copy link
Contributor

I thought the same. But yesterday I discussed this with @RomanNikitenko and found out that it was done deliberately. The reason was to not show there the whole URL which may be too long to fit the panel.

@slemeur
Copy link
Contributor Author

slemeur commented Jun 20, 2019

Then what's the benefit to the end-user to see that information?
Let's just display the proper URL, make it clickable and truncate it if it's too long. Consider displaying the full URL on hover in a tooltip.

@akurinnoy
Copy link
Contributor

yes, that makes sense to me
thanks!

@RomanNikitenko
Copy link
Member

RomanNikitenko commented Jun 20, 2019

The behavior came from task extension when I was reworking this one to plugin.
But I think the point was to match server defined from dashboard
server
So user defines some server in a config and then can see it on the panel as label and two buttons to go by reference

@slemeur
Copy link
Contributor Author

slemeur commented Jun 20, 2019

I think it's going to be confusing for the end-user. He might even not understand where this is coming from and there is no way to edit/configure that information.

As a user, when I run a task that is starting a process with a previewURL associated, I'm intending to find a place where I can see the previewURL (and all the ones started).
Also, as a user, seeing the panel for PreviewURLs, I'm intending to see the previewURLs, not the servers.
Also, as a user, I'd also be interested to find information about the task and the server related to the previewURLs - but those are secondary information.

@sleshchenko
Copy link
Member

@slemeur Looks like it's a good time to raise the issue that commands in Devfile do not support preview URLs. So, the described issue may be not actual for Che 7 with Devfiles or maybe it's needed to create an issue to support previewURL in commands of devfile.

@RomanNikitenko
Copy link
Member

@slemeur I don't mind, I just explained the history of this question...

@l0rd l0rd mentioned this issue Jun 27, 2019
85 tasks
@l0rd l0rd added severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. target/che7GA and removed target/che7GA labels Jun 27, 2019
@l0rd l0rd added this to the 7.0.0 milestone Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants