Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When editing the pre-defined tasks, all tasks should be displayed in the tasks.json file #13392

Closed
slemeur opened this issue May 22, 2019 · 3 comments
Assignees
Labels
kind/enhancement A feature request - must adhere to the feature request template.

Comments

@slemeur
Copy link
Contributor

slemeur commented May 22, 2019

Description

When the user is going to edit one of the pre-defined tasks, but the tasks.json does not exist, there is a new tasks.json that is created with only the selected task added to the file.
This behavior is confusing, the user would expect to see all the tasks that are available when doing "Run tasks".

We should make sure that when ever the user is going to edit the tasks, there is only a single source to edit all of them - so this way, the user knows where to go to find all of them and it stays consistent.

@slemeur slemeur added kind/enhancement A feature request - must adhere to the feature request template. team/ide labels May 22, 2019
@RomanNikitenko RomanNikitenko self-assigned this May 31, 2019
@RomanNikitenko RomanNikitenko added the status/in-progress This issue has been taken by an engineer and is under active development. label May 31, 2019
@RomanNikitenko
Copy link
Member

@slemeur
All Che tasks are available on plugin side, so we can copy them to tasks.json file.
However we need add plugin API to have ability copy all tasks provided by plugins to tasks.json file.
Is it OK for you if I copy all Che tasks within this issue and in a separate issue tasks provided by plugins (when we have required API)?

@slemeur
Copy link
Contributor Author

slemeur commented Jun 4, 2019

When you say "copy" how do you envision managing the task from the plugin and its copy?

  • Is it overhidding it?
  • Is it duplicating it?

(Ack for the API)

@RomanNikitenko
Copy link
Member

Actually, I think we don't need to copy the tasks from all plugins to tasks.json file.
It makes sense to provide Che commands as 'configured' tasks (copy them to tasks.json) because we want to provide way how user can edit them and sync with devfile.
Why we need to copy all tasks from plugins to tasks.json file - it's still question for me.
User has ability to click on 'configure' icon of any task and the configuration will be copied to tasks.json file, then user can edit it.

About overriding/duplicating.
When I added ability to configure tasks, I provided behavior that 'configured'(from tasks.json file) tasks have higher priority than 'detected'(from plugins) eclipse-theia/theia#4714 (comment).
So, for example, we have a task which comes from plugin. User wants to customize it => go to 'Run Task' menu, click on 'configure' action => the configuration is copied to tasks.json file => user edits it. From now on, 'Run Task' menu displays only overrided task - 'configured' task (from tasks.json file).

@RomanNikitenko RomanNikitenko added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Jun 19, 2019
@RomanNikitenko RomanNikitenko removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

No branches or pull requests

3 participants