Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate storing of workspaces converted from Devfile #13423

Closed
sleshchenko opened this issue May 27, 2019 · 2 comments
Closed

Deprecate storing of workspaces converted from Devfile #13423

sleshchenko opened this issue May 27, 2019 · 2 comments
Assignees
@mkuznyetsov
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. status/in-progress This issue has been taken by an engineer and is under active development.
Milestone
7.0.0

Comments

@sleshchenko
Copy link
Member

Description

Since we have an ability to create a workspace directly from Devfile, it's needed to deprecate the old method that converts Devfile to Workspace Config and store a workspace with it.
There are two places that use such an approach:

  1. DevfileService#createFromConfig. <- this should be deprecated and removed later.
  2. Accepting factory from Github repository URL. <- this should be reworked to create workspaces directly with Devfile.
@sleshchenko sleshchenko added kind/task Internal things, technical debt, and to-do tasks to be performed. team/platform labels May 27, 2019
@skabashnyuk
Copy link
Contributor

@l0rd I found this task important to do before GA since this API uses workspace config(aka Che6) as a backend to store devfile. That might be a bit confusing.

@skabashnyuk skabashnyuk added the severity/P1 Has a major impact to usage or development of the system. label May 27, 2019
@l0rd
Copy link
Contributor

l0rd commented May 28, 2019

@skabashnyuk agreed

@mkuznyetsov mkuznyetsov self-assigned this May 29, 2019
This was referenced May 31, 2019
Merged
Closed
@skabashnyuk skabashnyuk mentioned this issue Jun 10, 2019
Closed
17 tasks
@l0rd l0rd mentioned this issue Jun 11, 2019
Closed
This was referenced Jun 12, 2019
Closed
Closed
@mkuznyetsov mkuznyetsov mentioned this issue Jun 20, 2019
Merged
@sleshchenko sleshchenko added the status/in-progress This issue has been taken by an engineer and is under active development. label Jun 27, 2019
@l0rd l0rd mentioned this issue Jun 27, 2019
Closed
85 tasks
@l0rd l0rd added severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. target/che7GA and removed target/che7GA severity/P1 Has a major impact to usage or development of the system. labels Jun 27, 2019
@l0rd l0rd added this to the 7.0.0 milestone Jun 27, 2019
@skabashnyuk skabashnyuk mentioned this issue Jul 3, 2019
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkuznyetsov mkuznyetsov

Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. status/in-progress This issue has been taken by an engineer and is under active development.
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
4 participants
@l0rd @skabashnyuk @mkuznyetsov @sleshchenko