Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a confirmation dialog when Ctrl+W is pressed in the terminal #13580

Closed
sleshchenko opened this issue Jun 19, 2019 · 11 comments
Closed

Show a confirmation dialog when Ctrl+W is pressed in the terminal #13580

sleshchenko opened this issue Jun 19, 2019 · 11 comments
Assignees
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@sleshchenko
Copy link
Member

Description

ctrl+w is the standard "kill word" (aka werase) hotkey in terminal, and it's weird to see Che Theia tab closed after trying to erase the last word. This issue is a feature request to show a confirmation dialog when Ctrl+W is pressed in the terminal.

Reproduction Steps

  1. Start Che 7 Workspace.
  2. Open terminal.
  3. Press ctrl+w.
    Actual: Che Theia browser tab is closed.
    Expected: Ideal behavior would be the same as in native terminal - last word is erased, but I afraid whether it is possible to override such browser hotkey. So, at least a confirmation dialog should be shown before closing, because it's a typical thing when user press ctrl+w in terminal and does not to close tab.
@evidolob evidolob added the kind/enhancement A feature request - must adhere to the feature request template. label Jun 19, 2019
@evidolob evidolob mentioned this issue Jun 19, 2019
26 tasks
@amisevsk
Copy link
Contributor

This one has been bothering me for awhile as well -- I've closed a Che tab so many times :)

@azatsarynnyy
Copy link
Member

Have you tried confirmExit preference?

image

@azatsarynnyy
Copy link
Member

In Che Theia, the setting prevents reloading the page accidentally but doesn't prevent closing it.
In bare Theia, it works in both cases.

@slemeur
Copy link
Contributor

slemeur commented Jun 20, 2019

so it sounds more like a bug @azatsarynnyy

@slemeur slemeur added kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. and removed kind/enhancement A feature request - must adhere to the feature request template. labels Jun 20, 2019
@sleshchenko
Copy link
Member Author

sleshchenko commented Jun 21, 2019

The setting of Always ask preference affects dashboard also even after workspace stopping.
@azatsarynnyy Do you think we need a bug for that?
always_ask

Also, note that when I opened preferences - there was already set always but before I reloaded page without confirmation. I guess there is some bug in importing preferences for new workspace. I can investigate it more if needed.

@azatsarynnyy
Copy link
Member

Do you think we need a bug for that?

I think it is a bug. At least, that setting shouldn't affect the dasboard behavior.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 18, 2019
@che-bot
Copy link
Contributor

che-bot commented Dec 18, 2019

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot closed this as completed Dec 30, 2019
@amisevsk
Copy link
Contributor

Reopening this issue since I still hit this daily; capturing ctrl+w or at least popping a dialog should be the default -- we already catch F5 and other browser hotkeys. Anyone who has muscle memory for using ctrl+w in a terminal will be affected by this issue.

@amisevsk amisevsk reopened this Jan 20, 2020
@azatsarynnyy azatsarynnyy added the area/editor/theia Issues related to the che-theia IDE of Che label Jan 21, 2020
@che-bot che-bot closed this as completed Jan 29, 2020
@amisevsk
Copy link
Contributor

I'll fight che-bot if I have to.

@amisevsk amisevsk reopened this Jan 30, 2020
@amisevsk amisevsk added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jan 30, 2020
@azatsarynnyy azatsarynnyy mentioned this issue Feb 4, 2020
20 tasks
@che-bot che-bot closed this as completed Feb 12, 2020
@benoitf benoitf removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 12, 2020
@benoitf benoitf reopened this Feb 12, 2020
@benoitf
Copy link
Contributor

benoitf commented Feb 12, 2020

@amisevsk you need to remove stale as well

@amisevsk
Copy link
Contributor

Thanks @benoitf :)

@vzhukovs vzhukovs added the status/in-progress This issue has been taken by an engineer and is under active development. label Feb 19, 2020
@azatsarynnyy azatsarynnyy mentioned this issue Feb 19, 2020
16 tasks
@vzhukovs vzhukovs self-assigned this Feb 20, 2020
@vzhukovs vzhukovs removed the status/in-progress This issue has been taken by an engineer and is under active development. label Feb 20, 2020
@azatsarynnyy azatsarynnyy added this to the 7.10.0 milestone Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

8 participants