Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"/project" is not mount into the runtime container of the default python stacks #13594

Closed
slemeur opened this issue Jun 20, 2019 · 8 comments
Closed
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template. status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering.

Comments

@slemeur
Copy link
Contributor

slemeur commented Jun 20, 2019

Description

All default stacks are provided with runtime container.

In this runtime container the "/project" is not mount. So the default tasks are also not working.

Capture d’écran 2019-06-20 à 15 10 05

Reproduction Steps

  • Create workspace from stack "Python"
  • Add project "console-python"
  • open a terminal in "python" runtime container
  • check how to

OS and version:
Che 7 RC 2

@slemeur slemeur added kind/bug Outline of a bug - must adhere to the bug report template. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. team/languages labels Jun 20, 2019
@sleshchenko
Copy link
Member

@slemeur As far as I see console python Devfile contains another project https://github.com/eclipse/che-devfile-registry/blob/master/devfiles/python/devfile.yaml#L10
Maybe outdated stack from stacks.json is used? Can you made a screenshot of Dasboard when you choose this stack?

@slemeur
Copy link
Contributor Author

slemeur commented Jun 20, 2019

Capture d’écran 2019-06-20 à 16 11 43

@sleshchenko
Copy link
Member

sleshchenko commented Jun 20, 2019

@slemeur Ah, I got it. Actually, projects volume is mount but you created a workspace with project that you choose from samples.json but not that is provided by devfile. And project name is hardcoded in command, it's why it's failed.
As far as I know, Ann is reworking UI: UD should not propose projects from samples.json but it should show some info about project that is built-in. See Mario's mockup #13529

@sleshchenko
Copy link
Member

Note if you not chosen a project - then workspace will be created without projects. Ann's fixing it as well.

@slemeur I see two issues here, would you reformulate this issue/create new:

  • project from devfile is not respected by UD during workspace creation;
  • commands in python devfile have hard-coded project path, replace it with macros it if is available;

@ibuziuk ibuziuk changed the title "/project" is not mount into the runtime container of the default stacks "/project" is not mount into the runtime container of the default python stacks Jun 27, 2019
@l0rd l0rd mentioned this issue Jun 27, 2019
85 tasks
@l0rd l0rd added this to the 7.0.0 milestone Jun 27, 2019
@l0rd
Copy link
Contributor

l0rd commented Jun 27, 2019

Looks related to #13454

@sleshchenko
Copy link
Member

sleshchenko commented Jun 28, 2019

I think it's more related to ${current.project.path} #13636

@amisevsk
Copy link
Contributor

@slemeur Aside from #13636, can we confirm that this issue is still actual?

Checking the current eclipse-che/nightly-centos image with https://che-devfile-registry.prod-preview.openshift.io/ as the devfile registry gives a functional Python workspace (with the python-hello-world project). The other project (console-python) appears to not be available in the default UI.

As it stands, I've created #13936 to track the fixes coming from what @sleshchenko described.

The default command in the devfile is still hard-coded to "workingDir": "${CHE_PROJECTS_ROOT}/python-hello-world", but that may be acceptable for 7.0.0 (and unavoidable, since #13636 is currently not prioritized for 7.0.0)

@l0rd l0rd removed severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. target/che7GA labels Jul 22, 2019
@l0rd l0rd removed this from the 7.0.0 milestone Jul 22, 2019
@l0rd l0rd added the status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. label Jul 22, 2019
@l0rd
Copy link
Contributor

l0rd commented Jul 22, 2019

Closing it because we are not using sample.json anymore and this issue should be solved now.

@l0rd l0rd closed this as completed Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering.
Projects
None yet
Development

No branches or pull requests

4 participants