Can not create a new pull request from GitHub plugin

[vinokurig]

Description

Can not create a new pull request from GitHub plugin

Reproduction Steps

1. Add GitHub pull-request plugin
2. Open a workspace with a project cloned from GitHub
3. Checkout to a new branch and commit some changes.
4. Call Create Pull Request command

WRONG: Create process freezes, error occurred:
root ERROR [hosted-plugin: 11878] (node:11878) UnhandledPromiseRejectionWarning: TypeError: s.window.createInputBox is not a function

OS and version:
7.0.0
Diagnostics:

[slemeur]

@vparfonov : Could you please give an estimate on this issue. Would really prefer to have that for 7.0.0

[vinokurig]

@slemeur There is a PR that fixes the bug: eclipse-theia/theia#5187 AFAIK @JPinkney is working on it's comments

[JPinkney]

Yes, I'm still working on fixing up the comments. The reason its taking so long is I have to go back and re-do the way the createQuickPick api works (QuickInput/InputBox API's are all directly related) before I can start some of the improvements requested. The way that createQuickPick api was originally implemented doesn't allow for InputBox to be completed

[slemeur]

@l0rd + @rhopp + @tsmaeder + @nickboldt : This issue is making a lot of sense to be in 7.0.0. Having github plugin working with the ability of doing a PR is a must have.

[rhopp]

This issue is making a lot of sense to be in 7.0.0. Having github plugin working with the ability of doing a PR is a must have.

Agree.

[JPinkney]

@vinokurig and I have agreed to split the work for the last few fix-ups on the QuickInput/InputBox/QuickPick API's so we can get this in for 7.0.0

[slemeur]

Thanks @JPinkney and @vinokurig !

[tsmaeder]

@slemeur I have to disagree that this is a must have: there is a very simple workaround: open the PR on github.com. Not every bug and missing feature is 7.0.0-worthy.

[sunix]

@slemeur to me, before pushing a PR, you have to go through git commit ... so #13874 is a must have

[l0rd]

For me this is a '7.0.0' but not a severity/blocker. Rather a severity/P2.

[slemeur]

The value added by the ability to automate the creation of a PR and provide the reviewer link is key to Che. It highlights a big promise of Che in how it can help developers being more efficient.

If we don't have it, it'll be a functional gap from the targeted scope of the release. Something we have not been able to deliver.

[tsmaeder]

@slemeur time-quality-features, pick any two.

[slemeur]

@vparfonov What is the update on this?

[vinokurig]

fixed by eclipse-theia/theia#5187

[vinokurig]

fixed by eclipse-theia/theia#5187

[sunix]

Is it fixed in Che-theia 7.0.0-next ? milestone seems to be 7.0.0.

[vinokurig]

Yes, but the docker image is not built yet.

[sunix]

it is not merged yet ... eclipse-theia/theia#5890

[vinokurig]

Now it is merged :)