Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate tests for LSP and DAP Support in Che #13897

Closed
slemeur opened this issue Jul 18, 2019 · 12 comments
Closed

Automate tests for LSP and DAP Support in Che #13897

slemeur opened this issue Jul 18, 2019 · 12 comments
Labels
area/languages Issues related to Language extensions or plugins integration. kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@slemeur
Copy link
Contributor

slemeur commented Jul 18, 2019

Is your enhancement related to a problem? Please describe.

Provide automation testing for the Language Servers and Debug Adapters we package with Che.

@slemeur slemeur added the kind/enhancement A feature request - must adhere to the feature request template. label Jul 18, 2019
@slemeur slemeur added this to the 7.1.0 milestone Jul 18, 2019
@slemeur slemeur added the area/languages Issues related to Language extensions or plugins integration. label Jul 18, 2019
@tsmaeder
Copy link
Contributor

@slemeur not sure what you expect here.

@slemeur
Copy link
Contributor Author

slemeur commented Jul 19, 2019

Linking to: #13892 as it's a good illustration of why we need automated tests

@slemeur slemeur modified the milestones: 7.1.0, 7.2.0 Jul 24, 2019
@tsmaeder
Copy link
Contributor

@slemeur still not clear to me what you want here: tests for the language support plugins in che-plugin-registry? End-to-end?

@slemeur
Copy link
Contributor Author

slemeur commented Jul 26, 2019

We are packaging LS and DAG inside of Che and in the plugin-registry. We are running them in a different fashion and have mechanisms in place to make them running.

Let's say you have a LS that support 100% of the LSP and running without bugs:

  • How do you ensure that, the LS capabilities are all working when the LS is running in the context of Che?

How much of this can we get automated?

@slemeur
Copy link
Contributor Author

slemeur commented Jul 26, 2019

And if you look at this issue: #13892 it is exactly the type of issues we would like to catch. IE: LS works properly in VSCode but not in Che

@tsmaeder
Copy link
Contributor

tsmaeder commented Jul 26, 2019

Actually, #13892 is broken in Theia, not Che. If we want to catch such issues, we should do tests inside the Theia project, not Che.
If we can test Theia, we can test Theia running inside Che.

@sunix
Copy link
Contributor

sunix commented Jul 26, 2019

To me the goal in the description is pretty clear. Catch issues that we could have with the integration of LSP/DAP in Che.... which is different from Theia. You could have many ways to run LSP or DAP in Theia depends on the product. Things may work on Gitpod but not in Che, etc ...

@sunix
Copy link
Contributor

sunix commented Jul 26, 2019

about #13892, do we have the same issues in Gitpod ?

@gorkem
Copy link
Contributor

gorkem commented Jul 26, 2019

@tsmaeder we can not continue to manually test the LS and DAP implementations that we ship manually. Let's think of a solution so that this is no longer taking developer time.

@tsmaeder
Copy link
Contributor

What I 100% don't want is to do a series of UI tests for this: that was a disaster in Che 6 in that it never reliably forecast the quality of the software. We're going to investigate doing tests at the VS Code API level.

@gorkem
Copy link
Contributor

gorkem commented Jul 29, 2019

Agreed, I was thinking that debugging with test projects andlaunch.json files should be possible without UI.

@tsmaeder tsmaeder modified the milestones: 7.2.0, Backlog - Languages Oct 1, 2019
@slemeur slemeur added kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. and removed kind/enhancement A feature request - must adhere to the feature request template. labels Nov 12, 2019
@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 12, 2020
@che-bot
Copy link
Contributor

che-bot commented May 12, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot closed this as completed May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/languages Issues related to Language extensions or plugins integration. kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

5 participants