Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all workspace-related command from Theia File menu #13909

Closed
vitaliy-guliy opened this issue Jul 18, 2019 · 9 comments
Closed

Remove all workspace-related command from Theia File menu #13909

vitaliy-guliy opened this issue Jul 18, 2019 · 9 comments
Assignees
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system. status/in-progress This issue has been taken by an engineer and is under active development.
Milestone

Comments

@vitaliy-guliy
Copy link
Contributor

Theia File menu has items to open and close the workspace. But the workspace in Theia is something else that workspace in Che. In Theia it's a directory with projects.
Che works with predefined /projects directory which is never changed.
In that case it makes no sense to have Theia workspace related commands in file menu.
We can always load Theia and open /projects directory.

workspace

The solution could be to remove or hide Workspace* command from Theia File menu.
It will not confuse the user when dashboard sidebar is opened.

@vitaliy-guliy vitaliy-guliy added the kind/enhancement A feature request - must adhere to the feature request template. label Jul 18, 2019
@rhopp rhopp added the severity/P1 Has a major impact to usage or development of the system. label Jul 19, 2019
@rhopp rhopp added this to the 7.0.0 milestone Jul 19, 2019
@rhopp rhopp added the area/editor/theia Issues related to the che-theia IDE of Che label Jul 19, 2019
@rhopp
Copy link
Contributor

rhopp commented Jul 19, 2019

+1 for removing "workspace" references from Theia.

@benoitf
Copy link
Contributor

benoitf commented Jul 19, 2019

I think at F2F it was discussed that for example close workspace should be stop workspace instead

@rhopp
Copy link
Contributor

rhopp commented Jul 22, 2019

@benoitf Couldn't we do this in two steps? For GA, just remove these entries and for some future release bring them back with reimplemented functionality?

@tsmaeder
Copy link
Contributor

I'm doing this as part of changing to using projects workspace roots. See my message to che-dev 2 weeks ago. Propose to close this as a duplicate.

@l0rd
Copy link
Contributor

l0rd commented Jul 22, 2019

@tsmaeder duplicate of #13427 ?

@l0rd l0rd assigned tsmaeder and unassigned evidolob Jul 22, 2019
@l0rd l0rd added the status/in-progress This issue has been taken by an engineer and is under active development. label Jul 22, 2019
@slemeur slemeur added severity/P2 Has a minor but important impact to the usage or development of the system. and removed severity/P1 Has a major impact to usage or development of the system. labels Jul 24, 2019
@akurinnoy
Copy link
Contributor

@tsmaeder Hello, maybe you need some help getting rid of commands related to Theia workspaces?

@tsmaeder
Copy link
Contributor

Duplicate of duplicate of #13427

@vitaliy-guliy
Copy link
Contributor Author

@tsmaeder why did you close the issue? We still have a duplicate in the Theia File menu that has a different meaning.

@vitaliy-guliy vitaliy-guliy reopened this Sep 6, 2019
@tsmaeder
Copy link
Contributor

tsmaeder commented Sep 9, 2019

Because this will be fixed when we move to a workspace root-based system as a fix for #13427, so this is a duplicate.

@tsmaeder tsmaeder closed this as completed Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system. status/in-progress This issue has been taken by an engineer and is under active development.
Projects
None yet
Development

No branches or pull requests

8 participants