Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keycloak] The body of the email-verification was broken. #13917

Closed
7 tasks done
monaka opened this issue Jul 19, 2019 · 8 comments
Closed
7 tasks done

[Keycloak] The body of the email-verification was broken. #13917

monaka opened this issue Jul 19, 2019 · 8 comments
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. status/in-progress This issue has been taken by an engineer and is under active development.
Milestone

Comments

@monaka
Copy link
Member

monaka commented Jul 19, 2019

Describe the bug

The body of the mail from Keycloak was broken.

Che version

  • nightly

Steps to reproduce

  1. Registrer your account on Keycloak.
  2. Read the confirmation mail from Keycloak.
  3. You'll got a broken HTML mail.

Expected behavior

A valid HTML mail arrival.

Runtime

  • kubernetes (include output of kubectl version)
Client Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.0", GitCommit:"e8462b5b5dc2584fdcd18e6bcfe9f1e4d970a529", GitTreeState:"clean", BuildDate:"2019-06-21T13:09:06Z", GoVersion:"go1.12.6", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.0", GitCommit:"641856db18352033a0d96dbc99153fa3b27298e5", GitTreeState:"clean", BuildDate:"2019-03-25T15:45:25Z", GoVersion:"go1.12.1", Compiler:"gc", Platform:"linux/amd64"}

Screenshots

Screenshot 2019-07-19 at 14 35 44

Screenshot 2019-07-19 at 14 38 18

Installation method

  • I don't know Customized Helm Charts

Environment

  • my computer
    • Linux ChromeOS
  • Cloud
    • Azure

Additional context

Looks HTML content was escaped by msg() in FTL template.

@monaka monaka added the kind/bug Outline of a bug - must adhere to the bug report template. label Jul 19, 2019
@monaka
Copy link
Member Author

monaka commented Jul 19, 2019

The similar issue to keycloak/keycloak#4988 ?

@rhopp
Copy link
Contributor

rhopp commented Jul 19, 2019

@monaka Do you think this bug is important enought to be prioritized into Che 7 GA release?
cc @slemeur

@rhopp rhopp added the status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. label Jul 19, 2019
@monaka
Copy link
Member Author

monaka commented Jul 20, 2019

The viewpoint of functionality, this is not critical. Users who want to registration can click the link (or at least can copy/paste it to their web browser).

IMO, it's not blocker and just better to apply if someone could make patches before Che 7 GA release.

@slemeur
Copy link
Contributor

slemeur commented Jul 23, 2019

I think this should be landing in 7.1.0 cc @l0rd

@skabashnyuk
Copy link
Contributor

We can handle that.

@skabashnyuk skabashnyuk added severity/P1 Has a major impact to usage or development of the system. team/platform and removed status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. labels Jul 23, 2019
@slemeur
Copy link
Contributor

slemeur commented Jul 23, 2019

Thank you @skabashnyuk . You can handle it for 7.0?

@rhopp
Copy link
Contributor

rhopp commented Jul 23, 2019

I've just had instance running, so I tried this. Indeed adding ?no_esc to few places solves this issue (I've tried that on running instance changing this inside container, thus no PR).

@skabashnyuk
Copy link
Contributor

skabashnyuk commented Jul 23, 2019

Thank you @skabashnyuk . You can handle it for 7.0?

I think we can try.

@slemeur slemeur added this to the 7.0.0 milestone Jul 23, 2019
@skabashnyuk skabashnyuk added the status/in-progress This issue has been taken by an engineer and is under active development. label Jul 24, 2019
@skabashnyuk skabashnyuk added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. status/in-progress This issue has been taken by an engineer and is under active development.
Projects
None yet
Development

No branches or pull requests

5 participants