Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible future problem with language server initialization check #13955

Closed
Ohrimenko1988 opened this issue Jul 22, 2019 · 1 comment
Closed

Fix possible future problem with language server initialization check #13955

Ohrimenko1988 opened this issue Jul 22, 2019 · 1 comment
Assignees
@Ohrimenko1988
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone
7.1.0

Comments

@Ohrimenko1988
Copy link
Contributor

Is your enhancement related to a problem? Please describe.

Changes which was applied with PR #13851 may lead to possible problems in the future. For example, if language server has not been initialized the await ide.waitStatusBarTextAbsence('Starting Java Language Server', 360000); will be passed and the test will be failed in another place.

Describe the solution you'd like

We should add check that language server initialization has been started and after that, the test which checks language server initialization will have a valid result.
@Ohrimenko1988 Ohrimenko1988 added kind/enhancement A feature request - must adhere to the feature request template. team/che-qe labels Jul 22, 2019
@Ohrimenko1988 Ohrimenko1988 self-assigned this Jul 22, 2019
@l0rd l0rd added the severity/P2 Has a minor but important impact to the usage or development of the system. label Jul 22, 2019
@l0rd l0rd added this to the 7.1.0 milestone Jul 22, 2019
@Ohrimenko1988
Copy link
Contributor Author

Done #14046

@vkuznyetsov vkuznyetsov mentioned this issue Aug 9, 2019
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ohrimenko1988 Ohrimenko1988

Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
7.1.0
Development

No branches or pull requests
2 participants
@l0rd @Ohrimenko1988