-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate Language server metrics #14017
Comments
My investigations led me to a few things we need to do:
|
@JPinkney I'm afraid I don't quite understand your explanations:
|
In general, Prometheus recommend using scrape instead of push. Pushing is used only for short living (less than scrape interval) task. Another tricky part is authentication/authorization for both model push/pull. I think this is a separate story that can be handled in #13375 |
In #13270 we are asked to provide the following metrics:
The % of Language Servers requests that get a successful response
The % of Language Servers requests that get a successful response in under N seconds
However, since we do not control the language servers, I doubt we can provide these numbers directly: typically, language servers are hooked up to the VS Code API via https://github.com/Microsoft/vscode-languageserver-node, which we don't control.
So what I would propose is that we hook the VS Code API to provide those metrics. The purpose of this task is to prototype a solution that can provide that info to a yet-to-be-written API (see Investigate how to report metrics from workspaces #13375). I would expect that it this reporting API would be accessible from the theia back end server or from plugin host containers.
The text was updated successfully, but these errors were encountered: