Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add target="_blank" to the link for "Make a wish" button. #14036

Closed
monaka opened this issue Jul 26, 2019 · 2 comments · Fixed by #14037
Closed

Add target="_blank" to the link for "Make a wish" button. #14036

monaka opened this issue Jul 26, 2019 · 2 comments · Fixed by #14037
Assignees
@evidolob
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Milestone
7.1.0

Comments

@monaka
Copy link
Member

monaka commented Jul 26, 2019

Is your enhancement related to a problem? Please describe.

At least on ChromeOS, when you press a Make a wish button, it will transition the window showing IDE to the Gmail page.

This is trivial and easy to fix. It is no need to add 7.0.0 end game, IMO.

Describe the solution you'd like

This will be fixed by adding target="_blank" to the <a> element.

Describe alternatives you've considered

No.

Additional context

gmail
@monaka monaka added the kind/enhancement A feature request - must adhere to the feature request template. label Jul 26, 2019
@monaka monaka mentioned this issue Jul 26, 2019
Merged
@rhopp rhopp added the severity/P2 Has a minor but important impact to the usage or development of the system. label Jul 26, 2019
@rhopp rhopp added this to the 7.1.0 milestone Jul 26, 2019
@rhopp
Copy link
Contributor

rhopp commented Jul 26, 2019

Thanks for the PR. I'm triaging this for 7.1, as the PR is already existing.

@slemeur
Copy link
Contributor

slemeur commented Aug 2, 2019

@evidolob : To merge as soon as 7.0 is released.

@slemeur slemeur added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 2, 2019
sleshchenko referenced this issue Aug 27, 2019
@monaka @sleshchenko
Add target="_blank" to the link for "Make a wish" button. (eclipse#14…
6ebe485 
…036) (#14037)

Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>
skabashnyuk referenced this issue Jan 3, 2020
@monaka @sleshchenko
Add target="_blank" to the link for "Make a wish" button. (eclipse#14…
9379ea9 
…036) (#14037)

Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evidolob evidolob

Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Milestone
7.1.0
Development

Successfully merging a pull request may close this issue.

Add target="_blank" to the link for "Make a wish" button.
4 participants
@monaka @evidolob @rhopp @slemeur