Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using OpenShift.io for che plugin/devfile registry going forward #14266

Closed
amisevsk opened this issue Aug 16, 2019 · 12 comments
Closed

Using OpenShift.io for che plugin/devfile registry going forward #14266

amisevsk opened this issue Aug 16, 2019 · 12 comments
Labels
kind/question Questions that haven't been identified as being feature requests or bugs. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@amisevsk
Copy link
Contributor

Summary

Currently, Che uses openshift.io for default plugin and devfile registries. This will likely cause issues going forward, as those plugin registries are updated independently from the plugin and devfile registry images. In particular, these registries will likely have to be updated alongside releases of Che in order to maintain compatibility.

We need to define clear expectations on the update schedule for the production registries, and accommodate defaults in Che to work with these expecatations. I think that upstream Che should not use production deployments for SNAPSHOT builds.

Relevant information

Today, we ran into an issue where all Che deployments from the current snapshot version fail to start workspaces. This is because

Updating the production registries would mean breaking any workspaces that reference eclipse/che-theia/7.0.0-next directly or use it as a default. Further, since there's a manual update process for production deployments, we can't in general expect nightly releases to be available on production.

@amisevsk amisevsk added the kind/question Questions that haven't been identified as being feature requests or bugs. label Aug 16, 2019
@amisevsk
Copy link
Contributor Author

cc: @l0rd @rhopp @slemeur @nickboldt

@amisevsk
Copy link
Contributor Author

Opened PR #14267 to point current Che to prod-preview registries, which currently get nightly updates.

@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 16, 2019
@amisevsk
Copy link
Contributor Author

Additional context from the last time we updated the plugin registry: openshiftio/saas-openshiftio#1323 (comment)

@l0rd
Copy link
Contributor

l0rd commented Aug 19, 2019

@amisevsk currently the default is to use local registries (deployed alongside the che-server when using helm or the operator) and not to use osio. But that's not clear reading this issue's description.

Anyway I think using prod-preview is a step forward. Not sure if it will be the definitive solution: hosted che and upstream che stacks and plugins may need to be different at some point.

@rhopp
Copy link
Contributor

rhopp commented Aug 19, 2019

Agree... Any nightly-snapshot che instances should use its own-deployed registries. From what I'm aware, only minishift addon installation method doesn't deploy its own registries (do we still want to support that?)

@rhopp rhopp removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 19, 2019
@rhopp rhopp modified the milestone: 7.1.0 Aug 19, 2019
@gorkem
Copy link
Contributor

gorkem commented Aug 19, 2019

@l0rd My installation over the weekend with chectl to minishift was using the hosted registries which means it is broken. We need a plan to adjust chectl on minishift.

@ibuziuk
Copy link
Member

ibuziuk commented Aug 19, 2019

as I recall previously the plan was:

@l0rd
Copy link
Contributor

l0rd commented Aug 19, 2019

@gorkem agreed. I did not understand the problem at first. I think the description/title should be updated because that's a minishift add-on specific issue. Anyway using prod-preview registries is a good workaround but that's not ideal. Other options would be:

  • update the minishift addon to deploy the registries (but minishift is close to EOL)
  • update the che-operator to support deploying che single user and deprecating the minishift addon once and for all.

@johnmcollier
Copy link
Contributor

Note that Che deployed via ./deploy_che.sh will also use the hosted registries.

@amisevsk
Copy link
Contributor Author

Part of the reason I opened this issue is that we're still using hosted Che registries as default values in che.properties; any Che deployment that doesn't override those in a configmap or environment variable will hit this same problem.

My plan was to use prod-preview until all supported deployment methods come with a registry, and then set the values in che.properties to NULL. At least in that case, Che will fail to start, rather than failing in a more cryptic way (only some plugins don't work).

@che-bot
Copy link
Contributor

che-bot commented Feb 19, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 19, 2020
@amisevsk
Copy link
Contributor Author

This issue is out of date as Che gets deployed with compatible registries by all supported deployment methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question Questions that haven't been identified as being feature requests or bugs. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

7 participants