Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<workspaceid> placeholder for workspace namespace/project #14585

Closed
sparkoo opened this issue Sep 18, 2019 · 3 comments
Closed

<workspaceid> placeholder for workspace namespace/project #14585

sparkoo opened this issue Sep 18, 2019 · 3 comments
Assignees
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@sparkoo
Copy link
Member

sparkoo commented Sep 18, 2019

### Is your enhancement related to a problem? Please describe.
namespace/project can have placeholders now (#13488). Empty value would mean that workspace.id will be used as a namespace/project. It would now make sense to have <workspace.id> placeholder.

### Describe the solution you'd like
<workspace.id> placeholder for namespace/project.
https://github.com/eclipse/che/blob/master/assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties#L375
https://github.com/eclipse/che/blob/master/assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties#L581

### Additional context
Namespace placeholders was introduced as a fix for this #13488. Work on this after PR is merged #14524

As a consequence, PR #14828 is adding support for <workspaceid> in the namespace configuration. This issue is for updating the docs with the new information.

@sparkoo sparkoo added the kind/enhancement A feature request - must adhere to the feature request template. label Sep 18, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 18, 2019
@skabashnyuk skabashnyuk added team/platform and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Sep 18, 2019
@skabashnyuk skabashnyuk added this to the 7.4.0 milestone Sep 18, 2019
@benoitf benoitf added the severity/P2 Has a minor but important impact to the usage or development of the system. label Sep 18, 2019
@skabashnyuk skabashnyuk modified the milestones: 7.4.0, Backlog - Platform Oct 10, 2019
@l0rd l0rd added severity/P1 Has a major impact to usage or development of the system. and removed severity/P2 Has a minor but important impact to the usage or development of the system. labels Oct 15, 2019
@l0rd
Copy link
Contributor

l0rd commented Oct 15, 2019

Setting P1 to this issue because it looks necessary if we want to continue supporting one namespace per workspace strategy (even if the default is one namespace per user).

@sparkoo
Copy link
Member Author

sparkoo commented Oct 15, 2019

@skabashnyuk skabashnyuk modified the milestones: Backlog - Platform, 7.4.0 Oct 16, 2019
@metlos metlos changed the title <workspace.id> placeholder for workspace namespace/project <workspaceid> placeholder for workspace namespace/project Oct 18, 2019
@metlos
Copy link
Contributor

metlos commented Oct 18, 2019

I think it is already part of PR #14828 -> https://github.com/eclipse/che/pull/14828/files#diff-4eed0e9903e80a21758bbe991eee8c37R66
@metlos ?

Yes, #14828 is adding this functionality. I've updated the description of this issue to be basically docs-only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

6 participants