Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branding JSON for UD includes old CHE-6 links #14763

Closed
4 of 23 tasks
olexii4 opened this issue Oct 3, 2019 · 4 comments
Closed
4 of 23 tasks

Branding JSON for UD includes old CHE-6 links #14763

olexii4 opened this issue Oct 3, 2019 · 4 comments
Labels
area/dashboard area/doc Issues related to documentation kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.

Comments

@olexii4
Copy link
Contributor

olexii4 commented Oct 3, 2019

Describe the bug

Branding JSON for UD includes old CHE-6 links.

We have the next links in our product.json file:

  "docs" : {
    "devfile" : "/docs/che-7/using-developer-environments-workspaces.html#making-a-workspace-portable-using-a-devfile_using-developer-environments-workspaces",
    "workspace" : "/docs/what-are-workspaces.html",
    "factory" : "/docs/factories-getting-started.html",
    "organization": "/docs/organizations.html",
    "converting": "/docs/che-7/converting-a-che-6-workspace-to-a-che-7-devfile/",
    "general": "/docs"
  }

If we try those links, we will see the next che-6 redirections:
"/docs/organizations.html" -> "/che/docs/che-6/organizations.html"
"/docs/factories-getting-started.html" -> "/che/docs/che-6/factories-getting-started.html"
"/docs/what-are-workspaces.html" -> "/che/docs/che-6/what-are-workspaces.html"

We should provide the che-7 docs link at least for our docs.workspace.

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. Open workspaces tab and click the 'Learn more':
    Screenshot from 2019-10-03 12-29-05
    It redirects to
    Screenshot from 2019-10-03 14-00-25

Expected behavior

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Installation method

  • chectl
  • che-operator
  • minishift-addon
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify

Additional context

https://youtu.be/1veuVPTV40E

@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 3, 2019
@olexii4
Copy link
Contributor Author

olexii4 commented Oct 3, 2019

@slemeur WDYT?

@tsmaeder tsmaeder added area/dashboard team/ide2 kind/bug Outline of a bug - must adhere to the bug report template. area/doc Issues related to documentation severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Oct 3, 2019
@tsmaeder
Copy link
Contributor

tsmaeder commented Oct 3, 2019

P1 because this seems a low hanging fruit and it's a "doh!".

@akurinnoy
Copy link
Contributor

@slemeur @rkratky
Are you OK to change
"workspace" : "/docs/what-are-workspaces.html" to point to /docs/che-7/workspaces-overview/
and "general": "/docs" to point to /docs/che-7 ?

Also, I don't see any docs for organizations and factories for Che-7. Maybe, you know whether they are available?

@slemeur
Copy link
Contributor

slemeur commented Nov 11, 2019

@rkratky : I would think that now, the default docs should be che-7. Is that something you are planning soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard area/doc Issues related to documentation kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants