Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow endpoints section for VSCode extension sidecars in plugin meta.yaml #14766

Closed
mmorhun opened this issue Oct 3, 2019 · 3 comments
Closed
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.

Comments

@mmorhun
Copy link
Contributor

mmorhun commented Oct 3, 2019

Is your enhancement related to a problem? Please describe.

As for now we do not allow for Che plugins of VSCode extension (Che Theia plugin) type to have endpoints. But sometimes VSCode extension might have additional service which should be accessible from outside of workspace. To handle such situations I suggest to remove this artificial limitation.

Describe the solution you'd like

Allow for VSCode extension sidecar to have endpoints

@mmorhun mmorhun added the kind/enhancement A feature request - must adhere to the feature request template. label Oct 3, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 3, 2019
@mmorhun
Copy link
Contributor Author

mmorhun commented Oct 3, 2019

My own example: I've written Che plugin which has its backend in sidecar container and exposes some service to end user. The plugin also has UI which is implemented as Che Theia plugin. But there is no way to bring such a plugin into Che. From one side it is denied for VSCode extension (or Che Theia plugin) to bring two sidecars, from the other one (if put the service and UI into the same container) we have this endpoint limitation.

@l0rd @ibuziuk WDYT?

@AndrienkoAleksandr
Copy link
Contributor

@tolusha tolusha changed the title Allow enpoints section for VSCode extension sidecars in plugin meta.yaml Allow endpoints section for VSCode extension sidecars in plugin meta.yaml Oct 4, 2019
@tsmaeder tsmaeder added team/platform severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Oct 4, 2019
@l0rd l0rd added this to the Backlog - Platform milestone Oct 10, 2019
@l0rd
Copy link
Contributor

l0rd commented Oct 14, 2019

@mmorhun @AndrienkoAleksandr makes sense to me

@l0rd l0rd added severity/P1 Has a major impact to usage or development of the system. and removed severity/P2 Has a minor but important impact to the usage or development of the system. labels Oct 14, 2019
@skabashnyuk skabashnyuk removed this from the Backlog - Platform milestone Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

6 participants