Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply ability to select render for terminal #14772

Closed
AndrienkoAleksandr opened this issue Oct 4, 2019 · 2 comments
Closed

Apply ability to select render for terminal #14772

AndrienkoAleksandr opened this issue Oct 4, 2019 · 2 comments
Assignees
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.

Comments

@AndrienkoAleksandr
Copy link
Contributor

AndrienkoAleksandr commented Oct 4, 2019

Describe the solution you'd like

It would be nice to apply ability to select render for terminal widget. It should be useful for qa, because currently we are using canvas render for terminal and qa can not read content from widget. QA could use dom renderer and read content from terminal widget without problems. VSCode has such feature, so we can apply it to the upstream theia to align with VScode:

Screenshot_20191004_130529

VSCode has options: dom renderer and canvas(faster)

@AndrienkoAleksandr AndrienkoAleksandr added kind/enhancement A feature request - must adhere to the feature request template. status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Oct 4, 2019
@rhopp
Copy link
Contributor

rhopp commented Oct 4, 2019

This would be SUPER helpful! Didn't know, that something like this is possible!
As this has major impact on tests development, I'm setting this as P1 (feel free to disagree ;-))

@rhopp rhopp added area/editor/theia Issues related to the che-theia IDE of Che severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Oct 4, 2019
This was referenced Oct 11, 2019
@mmorhun mmorhun self-assigned this Oct 28, 2019
@mmorhun
Copy link
Contributor

mmorhun commented Oct 30, 2019

Fixed in eclipse-theia/theia#6471

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants