Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theia shows two dialogues when previewUrl is defined in command #14802

Closed
sparkoo opened this issue Oct 7, 2019 · 6 comments
Closed

Theia shows two dialogues when previewUrl is defined in command #14802

sparkoo opened this issue Oct 7, 2019 · 6 comments
Assignees
@mmorhun
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.

Comments

@sparkoo
Copy link
Member

sparkoo commented Oct 7, 2019

Is your enhancement related to a problem? Please describe.

When command has defined previewUrl attribute and command is executed, theia shows 2 dialogues, one for PreviewUrl and second is pop-up from port-plugin. This might be confusing to the user.

theia-previewurl

Describe the solution you'd like

We should probably show just PreviewUrl when it is defined. Or it should be at least more visible than port-plugin popup.

Describe alternatives you've considered

Additional context

Preview url in devfile is implemented here #13945
@sparkoo sparkoo added the kind/enhancement A feature request - must adhere to the feature request template. label Oct 7, 2019
@sparkoo sparkoo mentioned this issue Oct 7, 2019
Closed
7 tasks
@sparkoo sparkoo added status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. area/editor/theia Issues related to the che-theia IDE of Che labels Oct 7, 2019
@sparkoo sparkoo mentioned this issue Oct 8, 2019
Merged
@l0rd
Copy link
Contributor

l0rd commented Oct 8, 2019

+1 to show previewUrl only

@l0rd l0rd added severity/P1 Has a major impact to usage or development of the system. team/platform and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Oct 8, 2019
@l0rd
Copy link
Contributor

l0rd commented Oct 8, 2019

I have assigned this issue to team/platform but it can be team/ide2 as well.

@sparkoo
Copy link
Member Author

sparkoo commented Oct 8, 2019

@l0rd I'm not sure we have any Theia hackers in the team. Nothing to do with this issue on the server I guess.

@l0rd
Copy link
Contributor

l0rd commented Oct 8, 2019

Ok assigned to IDE2

@evidolob evidolob mentioned this issue Oct 31, 2019
Closed
22 tasks
@mmorhun
Copy link
Contributor

mmorhun commented Nov 6, 2019

So, to resolve this problem we have to improve ports plugin to ignore already exposed routes.
@benoitf are you ok with such solution?

@mmorhun mmorhun self-assigned this Nov 14, 2019
@mmorhun mmorhun mentioned this issue Nov 15, 2019
Merged
@mmorhun
Copy link
Contributor

mmorhun commented Nov 21, 2019

Fixed by changing Ports plugin to not to show its dialog if an exposed port has a preview url.

@mmorhun mmorhun closed this as completed Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmorhun mmorhun

Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@l0rd @sparkoo @mmorhun