Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm - registries does not work with default-host #14881

Closed
5 tasks done
sparkoo opened this issue Oct 14, 2019 · 1 comment
Closed
5 tasks done

Helm - registries does not work with default-host #14881

sparkoo opened this issue Oct 14, 2019 · 1 comment
Labels
area/install Issues related to installation, including offline/air gap and initial setup lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.

Comments

@sparkoo
Copy link
Member

sparkoo commented Oct 14, 2019

Describe the bug

When deploying che with helm in default-host mode, devfile and plugin registries are deployed, but does not work.

depoy command:
helm upgrade --install che --force --namespace che --set global.ingressDomain=$(minikube ip) --set global.serverStrategy=default-host --set cheImage=eclipse/che-server:nightly deploy/kubernetes/helm/che/

Registries chart templates ignore defaul-host settings and create these invalid hosts:

==> v1beta1/Ingress
NAME              HOSTS                               ADDRESS         PORTS  AGE
che-ingress       *                                   192.168.122.66  80     83m
devfile-registry  devfile-registry-che.192.168.39.34  80              1s
plugin-registry   plugin-registry-che.192.168.39.34   80              1s

Che version

  • latest

Steps to reproduce

  1. at local filesystem go to dir where you have che sources
  2. run the deploy helm command from the description
  3. go to minikube ip in your browser
  4. try to create workspace. It won't work, because devfile registry has wrong url. You can check by checking browser communication via browser devtools.

Expected behavior

The registries should work by default with helm charts and default-host. The registries should be deployed under url path something like /devfile-registry and /plugin-registry, but we have to be sure it won't conflict with anything else.

Runtime

  • minikube (include output of minikube version and kubectl version)

Screenshots

Installation method

  • helm (see description)

Environment

  • my computer
    • Linux

Workaround

deploy registries manually and set --set cheDevfileRegistry.deploy=false --set che.workspace.devfileRegistryUrl=${DEVFILE_REGISTRY_URL} --set chePluginRegistry.deploy=false --set che.workspace.pluginRegistryUrl=${PLUGIN_REGISTRY_URL} in the helm deploy

Additional context

#13647

@sparkoo sparkoo added the kind/bug Outline of a bug - must adhere to the bug report template. label Oct 14, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 14, 2019
@skabashnyuk skabashnyuk added area/install Issues related to installation, including offline/air gap and initial setup severity/P1 Has a major impact to usage or development of the system. and removed kind/bug Outline of a bug - must adhere to the bug report template. labels Oct 14, 2019
@skabashnyuk skabashnyuk added this to the Backlog - Platform milestone Oct 14, 2019
@ibuziuk ibuziuk removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 14, 2019
@che-bot
Copy link
Contributor

che-bot commented Jul 6, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 6, 2020
@che-bot che-bot closed this as completed Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/install Issues related to installation, including offline/air gap and initial setup lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants