cheimage parameter tag is applied to all images of Che deployment instead of Che server only

[mmorhun]

Describe the bug

if run the following command:

chectl server:start --installer=operator  --multiuser  --platform=minishift --cheimage=org/someimage:thetag

chectl will deploy Che master using given image but also will use given tag (thetag from the example above) for other images, which is wrong and could fail Che deployment at all (if use custom tag).

Che version

nightly

Steps to reproduce

1. Create a new tag for Che server and push image to dockerhub:

   docker tag eclipse/che-server:nightly myorg/che-server:thetag

2. Deploy Che server using the following command:

    chectl server:start --installer=operator --multiuser --platform=minishift --cheimage=myorg/che-server:thetag

3. Deployment of Che will fail, because other than che server images doesn't have the thetag tag.

Expected behavior

Only Che server image is affected by cheimage parameter

Runtime

minishift v1.34.1+c2ff9cb

Screenshots

Installation method

chectl

[benoitf]

hello @mmorhun it is not the operator that is using other tags ?

[mmorhun]

@benoitf may be. I don't know. I faced this issue while was testing my changes in Che master, so reported it.

[sleshchenko]

@benoitf It's me who asked Mykola to create this issue after he faced this.
The place where chectl replace tags for plugin/devfile registries and keycloak https://github.com/che-incubator/chectl/blob/master/src/api/kube.ts#L792
I understand the problem that code writers tried to solve - like plugin registry:7.1.0 might not compatible with che-server:7.0.0 but I believe we should invent another solution for this, like instead of reusing tag from cheimage flag, support like --version flag and use the correct images for that.

[dmytro-ndp]

There is no such an issue when installing Che using helm chart.
This issues doesn't allow to check PR using operator installer with custom che-server images like maxura/che-server:, for example: there was installation failure in time of installation of Che by command chectl server:start --k8spodreadytimeout=180000 --installer=operator --listr-renderer=verbose --platform=minikube --cheimage=maxura/che-server:15064:

Failed to pull image "eclipse/che-keycloak:15064"

LAST SEEN   TYPE      REASON                  OBJECT                                MESSAGE
5m39s       Normal    Scheduled               pod/che-operator-6d4d9bb5d8-f877k     Successfully assigned che/che-operator-6d4d9bb5d8-f877k to minikube
5m38s       Normal    Pulling                 pod/che-operator-6d4d9bb5d8-f877k     Pulling image "quay.io/eclipse/che-operator:nightly"
5m35s       Normal    Pulled                  pod/che-operator-6d4d9bb5d8-f877k     Successfully pulled image "quay.io/eclipse/che-operator:nightly"
5m35s       Normal    Created                 pod/che-operator-6d4d9bb5d8-f877k     Created container che-operator
5m35s       Normal    Started                 pod/che-operator-6d4d9bb5d8-f877k     Started container che-operator
5m39s       Normal    SuccessfulCreate        replicaset/che-operator-6d4d9bb5d8    Created pod: che-operator-6d4d9bb5d8-f877k
5m39s       Normal    ScalingReplicaSet       deployment/che-operator               Scaled up replica set che-operator-6d4d9bb5d8 to 1
5m9s        Normal    CREATE                  ingress/che                           Ingress che/che
4m45s       Normal    UPDATE                  ingress/che                           Ingress che/che
5m9s        Normal    Scheduled               pod/keycloak-64c764496c-jhl87         Successfully assigned che/keycloak-64c764496c-jhl87 to minikube
3m34s       Normal    Pulling                 pod/keycloak-64c764496c-jhl87         Pulling image "eclipse/che-keycloak:15064"
3m33s       Warning   Failed                  pod/keycloak-64c764496c-jhl87         Failed to pull image "eclipse/che-keycloak:15064": rpc error: code = Unknown desc = Error response from daemon: manifest for eclipse/che-keycloak:15064 not found: manifest unknown: manifest unknown
3m33s       Warning   Failed                  pod/keycloak-64c764496c-jhl87         Error: ErrImagePull
3m49s       Normal    BackOff                 pod/keycloak-64c764496c-jhl87         Back-off pulling image "eclipse/che-keycloak:15064"
5s          Warning   Failed                  pod/keycloak-64c764496c-jhl87         Error: ImagePullBackOff
5m9s        Normal    SuccessfulCreate        replicaset/keycloak-64c764496c        Created pod: keycloak-64c764496c-jhl87
5m9s        Normal    CREATE                  ingress/keycloak                      Ingress che/keycloak
5m9s        Normal    ScalingReplicaSet       deployment/keycloak                   Scaled up replica set keycloak-64c764496c to 1
4m45s       Normal    UPDATE                  ingress/keycloak                      Ingress che/keycloak
5m34s       Normal    Scheduled               pod/postgres-84f696668c-7c7fk         Successfully assigned che/postgres-84f696668c-7c7fk to minikube
5m33s       Normal    Pulling                 pod/postgres-84f696668c-7c7fk         Pulling image "centos/postgresql-96-centos7:9.6"
5m29s       Normal    Pulled                  pod/postgres-84f696668c-7c7fk         Successfully pulled image "centos/postgresql-96-centos7:9.6"
5m29s       Normal    Created                 pod/postgres-84f696668c-7c7fk         Created container postgres
5m28s       Normal    Started                 pod/postgres-84f696668c-7c7fk         Started container postgres
5m34s       Normal    SuccessfulCreate        replicaset/postgres-84f696668c        Created pod: postgres-84f696668c-7c7fk
5m34s       Normal    ExternalProvisioning    persistentvolumeclaim/postgres-data   waiting for a volume to be created, either by external provisioner "k8s.io/minikube-hostpath" or manually created by system administrator
5m34s       Normal    Provisioning            persistentvolumeclaim/postgres-data   External provisioner is provisioning volume for claim "che/postgres-data"
5m34s       Normal    ProvisioningSucceeded   persistentvolumeclaim/postgres-data   Successfully provisioned volume pvc-cd449151-fd5c-11e9-a9ed-fa163e216d9e
5m34s       Normal    ScalingReplicaSet       deployment/postgres                   Scaled up replica set postgres-84f696668c to 1