-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a maven sample for the maven stack #15216
Comments
I don't mind the sample, but we need a way to force VS Code Java to use maven. Find out if we can use a preference in the devfile for this. Otherwise, remove the gradle support from the sample. Make sure console-simple is not used in our gradle stack |
I wonder if we could just separate the maven and gradle parts into two different branches in the console-java-simple repo? I've gone with this idea in: and then the corresponding update in the devfile registry: The only reason I'm advocating this way is that I personally always use this stack as a go-to if I'm ever doing something simple with java and it serves as a super easy starter template. Plus its rarely touched so the maintenance is almost non-existent |
I would advocate against using branches: branches are for different development paths of the same thing. A maven and a console sample would warrant a different repo, IMO. Think of it this way: what would master contain? Maven or Gradle? |
My idea was to be similiar to the che-sidecars where master would just be a readme that points to the maven/gradle branches but I know thats not ideal. But there's also a few other ways:
@tsmaeder Which one do you think we should go with? |
I would go with 1. Repos are cheap, right? |
Issues go stale after Mark the issue as fresh with If this issue is safe to close now please do so. Moderators: Add |
Closing as obsolete |
Is your enhancement related to a problem? Please describe.
We use the java sample [1] with a Grandle build-system by default for the java-maven stack [2].
It confuses and leads to such quesitons [3]
[1] https://github.com/che-samples/console-java-simple
[2] https://github.com/eclipse/che-devfile-registry/blob/master/devfiles/java-maven/devfile.yaml
[3] https://stackoverflow.com/questions/58863192/eclipse-che-workspace-wont-recognize-new-maven-dependencies
Describe the solution you'd like
Use a sample with maven build-system for the java-maven stack.
The text was updated successfully, but these errors were encountered: