Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Hosted Che 'k8s-image-puller' to the upstream needs #15385

Closed
Tracked by #14879
l0rd opened this issue Dec 3, 2019 · 5 comments
Closed
Tracked by #14879

Adapt Hosted Che 'k8s-image-puller' to the upstream needs #15385

l0rd opened this issue Dec 3, 2019 · 5 comments
Labels
kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@l0rd
Copy link
Contributor

l0rd commented Dec 3, 2019

Is your enhancement related to a problem?

Image pulling is usually the workspace startup task that takes more time. And a typical Che workspace needs > 7 images to be pulled.

Describe the solution you'd like

We can pre-pull the default images used by Che workspaces on every node of the Kubernetes cluster where Che is going to run. This is something that we have implemented for the Hosted version of che (che.openshift.io) with the kubernetes-image-puller.

This issue is to adapt the k8s-img-puller to upstream che (if needed) and add the documentation to use in che-docs.

@l0rd l0rd added kind/enhancement A feature request - must adhere to the feature request template. team/osio severity/P1 Has a major impact to usage or development of the system. labels Dec 3, 2019
@l0rd
Copy link
Contributor Author

l0rd commented Dec 3, 2019

Related to redhat-developer/rh-che#1428

@amisevsk
Copy link
Contributor

amisevsk commented Dec 3, 2019

This may require some work on the k8s-image-puller side as well, as the default case is designed to support impersonating multiple users through fabric8-oso-proxy. There is a 'local testing' option which is more in line with a common use case, but it should be improved to be more usable.

@ibuziuk ibuziuk added this to the Backlog - Hosted Che milestone Dec 12, 2019
@ibuziuk ibuziuk changed the title Document how to use k8s-image-puller Adapt rh-che 'k8s-image-puller' to the upstream needs Dec 12, 2019
@ibuziuk ibuziuk changed the title Adapt rh-che 'k8s-image-puller' to the upstream needs Adapt Hosted Che 'k8s-image-puller' to the upstream needs Dec 12, 2019
@slemeur slemeur added kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. and removed kind/enhancement A feature request - must adhere to the feature request template. labels Jan 27, 2020
@ibuziuk ibuziuk modified the milestones: Backlog - Hosted Che, 7.9.0 Jan 29, 2020
@ibuziuk
Copy link
Member

ibuziuk commented Feb 10, 2020

The upstream repo under che-incubator - https://github.com/che-incubator/kubernetes-image-puller
docs - eclipse-che/che-docs#1085

@ibuziuk
Copy link
Member

ibuziuk commented Feb 18, 2020

I believe we should close the issue once the doc PR is merged

@ibuziuk
Copy link
Member

ibuziuk commented Feb 19, 2020

@rkratky @themr0c closing this issue - please review the docs PR eclipse-che/che-docs#1085

@ibuziuk ibuziuk closed this as completed Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants