Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cpu limits to che-plugin-broker #15543

Closed
anselmov opened this issue Dec 19, 2019 · 3 comments
Closed

add cpu limits to che-plugin-broker #15543

anselmov opened this issue Dec 19, 2019 · 3 comments
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@anselmov
Copy link

Is your enhancement related to a problem? Please describe.

I run che-server 7.5.1 on a corporate k8s cluster where it is required to specify resource limits for every deployment. The workspace creation process fails because there are no cpu limits for workspaceXXXX.che-plugin-broker.

Describe the solution you'd like

So I tried a dirty fix on Containers.java which resolves the issue. Now I wonder what would be a clean way to add this cpu limit ? Maybe we can already add it without patching existing code ?
@anselmov anselmov added the kind/enhancement A feature request - must adhere to the feature request template. label Dec 19, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Dec 19, 2019
@tolusha tolusha added area/install Issues related to installation, including offline/air gap and initial setup severity/P2 Has a minor but important impact to the usage or development of the system. team/deploy area/chectl Issues related to chectl, the CLI of Che and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Dec 20, 2019
@anselmov
Copy link
Author

anselmov commented Feb 5, 2020

Any update? Thanks.

@tolusha tolusha added team/controller and removed area/chectl Issues related to chectl, the CLI of Che area/install Issues related to installation, including offline/air gap and initial setup team/deploy labels Feb 5, 2020
@tolusha
Copy link
Contributor

tolusha commented Feb 5, 2020

/cc @sleshchenko

@sleshchenko
Copy link
Member

Seems it duplicates #13709.

There already a PR that should fix the described issue #15977

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tolusha @sleshchenko @anselmov @che-bot