Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chectl add ability to override Eclipse Che custom resources definitions #15684

Closed
AndrienkoAleksandr opened this issue Jan 14, 2020 · 4 comments
Assignees
Labels
area/chectl Issues related to chectl, the CLI of Che area/install Issues related to installation, including offline/air gap and initial setup kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@AndrienkoAleksandr
Copy link
Contributor

AndrienkoAleksandr commented Jan 14, 2020

Is your enhancement related to a problem? Please describe.

In the chectl we have an option --che-operator-cr-yaml to set up Eclipse Che custom resources yaml. But to change few properties in the custom resources user should COPY-PASTE all yaml file. And before that user should somehow find this operator-cr-yaml compatible with desired Eclipse Che version installation.
It is not user friendly and this option hard to use to define configuration changes in the documentation. For example you want to provide some properties which user should modify, but before that you need to explain that user should find somewhere yaml, search needed fields from pretty big list, and edit target properties. It looks not trivial and requires to much actions from user.

Describe alternatives you've considered

It would be nice to have some argument to apply file with overrides Eclipse Che custom resources, where is user can define only desired properties list to override.

As an example if users wants to override PVCs class name then they executes: chectl server:start --che-cluster-patch-path ./checluster-cr-overrides.yaml where checluster-cr-overrides.yaml has the following content:

spec:
  storage:
    postgresPVCStorageClassName: "my-custom"
    workspacePVCStorageClassName: "my-custom"

P.S. The similar argument could be considered to be implemented to provide values overrides for helm chart. But definitely in a scope if new issue.

@AndrienkoAleksandr AndrienkoAleksandr added kind/enhancement A feature request - must adhere to the feature request template. team/deploy labels Jan 14, 2020
@AndrienkoAleksandr AndrienkoAleksandr added this to the Backlog - Deploy milestone Jan 14, 2020
@AndrienkoAleksandr AndrienkoAleksandr changed the title chectl apply ability to override Eclipse Che custom resources definitions chectl add ability to override Eclipse Che custom resources definitions Jan 14, 2020
@sleshchenko
Copy link
Member

It totally makes sense! I think it's really great an ability to customize everything within chectl command without an endless list of command arguments.
The same argument could be used later for server:update command.

@gattytto
Copy link

gattytto commented Jan 15, 2020

is this related? #15600 #15601

@l0rd
Copy link
Contributor

l0rd commented Jan 15, 2020

@AndrienkoAleksandr it makes sense, that's a good idea. To be consistent with the existing --che-operator-cr-yaml flag I would name the new flag --che-operator-cr-patch.

@l0rd l0rd added the severity/P1 Has a major impact to usage or development of the system. label Jan 15, 2020
@l0rd
Copy link
Contributor

l0rd commented Jan 15, 2020

@gattytto that's a good point. When fixing this one we may fix the 2 issues you are mentioning too.

@l0rd l0rd added area/chectl Issues related to chectl, the CLI of Che area/install Issues related to installation, including offline/air gap and initial setup labels Jan 15, 2020
@tolusha tolusha self-assigned this Feb 14, 2020
@tolusha tolusha closed this as completed Feb 14, 2020
@tolusha tolusha modified the milestones: Backlog - Deploy, 7.9.0 Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/chectl Issues related to chectl, the CLI of Che area/install Issues related to installation, including offline/air gap and initial setup kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants