Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[workspace-operator] Adapt controller to support unique ingresses #15990

Closed
amisevsk opened this issue Feb 12, 2020 · 2 comments
Closed

[workspace-operator] Adapt controller to support unique ingresses #15990

amisevsk opened this issue Feb 12, 2020 · 2 comments
Labels
engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Milestone
Backlog - Controller

Comments

@amisevsk
Copy link
Contributor

Describe the bug

To work with Che 7.8 components, the che-workspace operator needs to support creating one ingress per plugin endpoint (even when they point at the same place). Currently, the welcome page in the workspace simply reports a 502 error.

See also:

Che issue: #15410 and PR: #15432
@amisevsk amisevsk added kind/bug Outline of a bug - must adhere to the bug report template. engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. labels Feb 12, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Feb 12, 2020
@benoitf benoitf added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Feb 12, 2020
@benoitf benoitf added this to the Backlog - Controller milestone Feb 12, 2020
@benoitf
Copy link
Contributor

benoitf commented Feb 12, 2020

setting P1 as it's breaking all webviews (when using VS Code extensions) (not only welcome page)

@amisevsk amisevsk mentioned this issue Feb 12, 2020
Merged
@sleshchenko sleshchenko mentioned this issue Apr 15, 2020
Merged
@amisevsk
Copy link
Contributor Author

With the current state of the controller (post-refactoring), this issue is resolved. However, we cannot move to using e.g. webviews, as deploying 7.9.0 and up is blocked by #16568 and oauth-proxy issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
Backlog - Controller
Development

No branches or pull requests
3 participants
@benoitf @amisevsk @che-bot