Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove API call after Python Django preview widget has been fixed #16076

Closed
ScrewTSW opened this issue Feb 19, 2020 · 1 comment
Closed

Remove API call after Python Django preview widget has been fixed #16076

ScrewTSW opened this issue Feb 19, 2020 · 1 comment
Labels
area/qe kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.
Milestone
Backlog - QE

Comments

@ScrewTSW
Copy link
Member

Is your enhancement related to a problem? Please describe.

#15053

Describe the solution you'd like

Remove the Axios GET and replace it with UI test directly inside the IDE.
Currently we are getting the URL from DialogWindow and then closing it while we call GET for modified preview URL to verify that we get 200 HTML code.
I want to remove the Axios get and click OpenLink in DialogWindow instead to verify the content inside the PreviewWidget directly

Describe alternatives you've considered

alternative would be to leave the test as it is - I'm strongly against this alternative

Additional context

Currently the default index page for Python Django deployment returns 404 but also sends page content. This messes up the PreviewWidget, causing it to display a default blank page instead of showing the page content. Until this is fixed, the current test logic is a workaround.
https://github.com/eclipse/che/pull/15831/files#diff-9debcc656c7ef9f0b57e073cf6a73c4bR36
@ScrewTSW ScrewTSW added the kind/enhancement A feature request - must adhere to the feature request template. label Feb 19, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Feb 19, 2020
@ScrewTSW ScrewTSW mentioned this issue Feb 19, 2020
Merged
@benoitf benoitf added area/qe and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Feb 19, 2020
@rhopp rhopp added this to the Backlog - QE milestone Feb 26, 2020
@dmytro-ndp dmytro-ndp added the severity/P1 Has a major impact to usage or development of the system. label Apr 2, 2020
@che-bot
Copy link
Contributor

che-bot commented Oct 1, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 1, 2020
@che-bot che-bot closed this as completed Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/qe kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
Backlog - QE
Development

No branches or pull requests
5 participants
@benoitf @dmytro-ndp @rhopp @ScrewTSW @che-bot