Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workspace stop time increased sufficiently in the 7.9.0 version #16200

Closed
2 of 3 tasks
ibuziuk opened this issue Mar 2, 2020 · 2 comments · Fixed by #16207
Closed
2 of 3 tasks

Workspace stop time increased sufficiently in the 7.9.0 version #16200

ibuziuk opened this issue Mar 2, 2020 · 2 comments · Fixed by #16207
Assignees
@skabashnyuk
Labels
area/che-server kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.10

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Mar 2, 2020 •
edited
Loading

Describe the bug

Workspace stop time increased sufficiently after the 7.9.0 update from 2 to 40 seconds

image

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  • Start workspace
  • Wait until started
  • Stop Workspace
  • Error: workspace will be marked as stopped only after 40 seconds

Additional context

The current suspect is che.infra.kubernetes.pod.termination_grace_period_sec=0 that might not be set in the pod spec. By default terminationGracePeriodSeconds is 30 on k8s

https://github.com/eclipse/che/blob/master/assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties#L405
@ibuziuk ibuziuk added kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. area/che-server and removed severity/P1 Has a major impact to usage or development of the system. labels Mar 2, 2020
@amisevsk
Copy link
Contributor

amisevsk commented Mar 2, 2020

I checked the yaml for a deployment directly and it does contain terminationGracePeriodSeconds: 30 whereas 7.8.0 had terminationGracePeriodSeconds: 0

@ibuziuk
Copy link
Member Author

ibuziuk commented Mar 2, 2020

@amisevsk thanks, that was the main suspect ;)

@ibuziuk ibuziuk mentioned this issue Mar 2, 2020
Closed
24 tasks
@ibuziuk ibuziuk changed the title Workspace stop time increased sufficiently after the 7.9.0 update. Workspace stop time increased sufficiently in the 7.9.0 version Mar 2, 2020
@skabashnyuk skabashnyuk added this to the 7.10.0 milestone Mar 3, 2020
@skabashnyuk skabashnyuk self-assigned this Mar 3, 2020
@skabashnyuk skabashnyuk mentioned this issue Mar 3, 2020
Merged
@ibuziuk ibuziuk mentioned this issue Mar 5, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skabashnyuk skabashnyuk

Labels
area/che-server kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.10
3 participants
@ibuziuk @skabashnyuk @amisevsk