Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container name for brokers can be created longer than 63 chars #16288

Closed
amisevsk opened this issue Mar 9, 2020 · 1 comment · Fixed by #16289
Closed

Container name for brokers can be created longer than 63 chars #16288

amisevsk opened this issue Mar 9, 2020 · 1 comment · Fixed by #16289
Assignees
@amisevsk
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.

Comments

@amisevsk
Copy link
Contributor

amisevsk commented Mar 9, 2020

Is your task related to a problem? Please describe.

The plugin brokers used in a workspace are named based off the image reference they use. This means that for images referenced by digest, the name will be longer than 63 characters, causing an error on workspace start:

Error: Failed to run the workspace: "The container name 'che-plugin-metadata-broker-sha256-7b868470f7b63d9da10a788d26abf4c076f90dc4c7de24d1298a8160c9a3dcc9' exceeds the allowed limit of 63 characters."

Describe the solution you'd like

We should choose names more intelligently and force them to fewer than 63 characters.
@amisevsk amisevsk added kind/bug Outline of a bug - must adhere to the bug report template. area/infra/kubernetes labels Mar 9, 2020
@amisevsk amisevsk self-assigned this Mar 9, 2020
@amisevsk
Copy link
Contributor Author

amisevsk commented Mar 9, 2020

cc: @davidfestal

@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Mar 9, 2020
@amisevsk amisevsk mentioned this issue Mar 9, 2020
Merged
@ibuziuk ibuziuk added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Mar 9, 2020
@nickboldt nickboldt mentioned this issue Mar 9, 2020
Closed
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amisevsk amisevsk

Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Generate broker container names more sensibly amisevsk/che
3 participants
@ibuziuk @amisevsk @che-bot