Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Could cheFlavor be an env var like all the other settings moved from defaults.go ? #16305

Closed
nickboldt opened this issue Mar 10, 2020 · 2 comments
Closed

Could cheFlavor be an env var like all the other settings moved from defaults.go ? #16305

nickboldt opened this issue Mar 10, 2020 · 2 comments
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator area/install Issues related to installation, including offline/air gap and initial setup kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone
7.13

Comments

@nickboldt
Copy link
Contributor

Is your enhancement related to a problem? Please describe.

If we could externalize cheFlavour maybe we could make che-operator even MORE generic between che and crw versions.

Describe the solution you'd like

Following the path of eclipse-che/che-operator@e9c5d3f and #15874 we could externalize cheFlavor.

cc: @davidfestal
@nickboldt nickboldt added kind/enhancement A feature request - must adhere to the feature request template. area/install Issues related to installation, including offline/air gap and initial setup area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator area/whitelabel labels Mar 10, 2020
@davidfestal
Copy link
Contributor

Yes, that would be helpful to make upstream / downstream flow cleaner

@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Mar 10, 2020
@l0rd l0rd added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Mar 10, 2020
@tolusha tolusha added this to the Backlog - Deploy milestone Mar 21, 2020
@tolusha tolusha removed this from the Backlog - Deploy milestone May 6, 2020
@tolusha tolusha mentioned this issue May 8, 2020
Closed
@tolusha
Copy link
Contributor

tolusha commented May 13, 2020

Fixed in eclipse-che/che-operator#247

@tolusha tolusha closed this as completed May 13, 2020
@tolusha tolusha added this to the 7.13 milestone May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator area/install Issues related to installation, including offline/air gap and initial setup kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
7.13
Development

No branches or pull requests
5 participants
@nickboldt @l0rd @davidfestal @tolusha @che-bot