Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt tasks to upstream changes #16331

Closed
RomanNikitenko opened this issue Mar 12, 2020 · 3 comments
Closed

Adapt tasks to upstream changes #16331

RomanNikitenko opened this issue Mar 12, 2020 · 3 comments
Assignees
@RomanNikitenko
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.

Comments

@RomanNikitenko
Copy link
Member

RomanNikitenko commented Mar 12, 2020 •
edited
Loading

Is your task related to a problem? Please describe.

I tested the influence of the PR in theia repo related to support presentation.panel in task config on che tasks.

The PR is still under review, I tested the current state of the PR using che-in-che development

Looks like we will need some adaptation on che-theia side:

  • support presentation for che task schema
  • support presentation functionality for che tasks
  • status marker for not che task title (shell, npm, typescript, ...) is broken
  • output for not che tasks is not displayed for me

task_presentation_bug
@RomanNikitenko RomanNikitenko added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Mar 12, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Mar 12, 2020
@RomanNikitenko
Copy link
Member Author

RomanNikitenko commented Mar 12, 2020 •
edited
Loading

Output for a typescript task is absent:

output_tasks

@tolusha tolusha added severity/P1 Has a major impact to usage or development of the system. area/editor/theia Issues related to the che-theia IDE of Che and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Mar 13, 2020
@azatsarynnyy azatsarynnyy mentioned this issue Apr 2, 2020
Closed
12 tasks
@RomanNikitenko RomanNikitenko self-assigned this Apr 8, 2020
@RomanNikitenko RomanNikitenko added the status/in-progress This issue has been taken by an engineer and is under active development. label Apr 8, 2020
@RomanNikitenko RomanNikitenko mentioned this issue Apr 20, 2020
Merged
@RomanNikitenko RomanNikitenko added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Apr 20, 2020
@RomanNikitenko
Copy link
Member Author

I investigated the issue and I would say we can separate this one on the following problems:

  • bug: an output for vs code/theia tasks is not displayed
  • bug: status marker for vs code/theia tasks is broken
  • enhancement: support presentation.panel related functionality for che tasks

Within current issue I have fixed displaying an output for vs code/theia tasks, please see eclipse-che/che-theia#717.

Also I investigated status marker problem.
The cause of the problem is the corresponding terminal widget can not be found due to upstream changes.
Fix of this problem is quite simple, but now it does not make sense without fixing #15742. Because now theia reuses terminal widgets, so without fixing #15742 user will face with the behavior like:

  • running a vs code task
  • the corresponding marker is set to terminal widget when the task is completed
  • run another vs code task ---> theia reuses terminal widget for completed task ---> task is running, but the terminal widget has a status marker from a previous task.

Fixing #15742 will help at this step set in progress status and avoid confusing behavior.

About enhancement related to presentation.panel support for che tasks.
che tasks are run using API by creating terminal with the corresponding shell arguments. It creates a new terminal for every execution of a task from plugin side.
So I think at the moment we don't have an ability to provide presentation.panel functionality using current API from task-plugin side.

I believe the true way to achieve this goal is:

  • separate creating task terminal and running process logic
  • provide way for creating a task terminal from client side(not plugin side)
  • che task runner should only run a process and doesn't contain terminal creating logic
  • provide presentation.panel functionality

So for:

  • the status marker bug
    and
  • the presentation.panel enhancement

I prefer to create separate issues as these problems are quite different and require additional efforts.

@RomanNikitenko
Copy link
Member Author

RomanNikitenko commented Apr 20, 2020 •
edited
Loading

I created the following issues:

@RomanNikitenko RomanNikitenko removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomanNikitenko RomanNikitenko

Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tolusha @RomanNikitenko @che-bot