Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle large amount of debug log in workspace loader #16368

Closed
akurinnoy opened this issue Mar 16, 2020 · 1 comment
Closed

Handle large amount of debug log in workspace loader #16368

akurinnoy opened this issue Mar 16, 2020 · 1 comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.11

Comments

@akurinnoy
Copy link
Contributor

Is your task related to a problem? Please describe.

#15983 introduced ability to restart a workspace with debug mode enabled. In some cases, when amount of logs will be rather large to show by workspace loader, this may cause memory performance issues because of large number of DOM nodes to manipulate.

Describe the solution you'd like

Keep in DOM certain amount of latest lines of logs, but allow users to download all logs at once.

Describe alternatives you've considered

Additional context
@akurinnoy akurinnoy added kind/task Internal things, technical debt, and to-do tasks to be performed. team/controller labels Mar 16, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Mar 16, 2020
@ibuziuk ibuziuk added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Mar 16, 2020
@olexii4
Copy link
Contributor

olexii4 commented Mar 27, 2020

Fixed in https://github.com/eclipse/che-workspace-loader/pull/6/files#diff-291b63e7e93f33e96bd0d0184764cb64R78

@olexii4 olexii4 closed this as completed Mar 27, 2020
@sleshchenko sleshchenko added this to the 7.11 milestone Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.11
Development

No branches or pull requests
5 participants
@ibuziuk @sleshchenko @olexii4 @akurinnoy @che-bot