Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monaco Editor works in the main thread instead of web-worker #16516

Closed
4 of 23 tasks
olexii4 opened this issue Apr 1, 2020 · 2 comments · Fixed by eclipse-che/che-dashboard#352
Closed
4 of 23 tasks

Monaco Editor works in the main thread instead of web-worker #16516

olexii4 opened this issue Apr 1, 2020 · 2 comments · Fixed by eclipse-che/che-dashboard#352
Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone
7.37

Comments

@olexii4
Copy link
Contributor

olexii4 commented Apr 1, 2020 •
edited
Loading

Describe the bug

Monaco Editor works in the main thread instead of web-worker. We can see the error:

GET {Che Host}/dashboard/app/editor.worker.module.js 404
... Could not create web worker(s). Falling back to loading web worker code in the main thread, which might cause UI freezes.

It is reproduced locally on single-user and multi-user CHE v7.11.0 and on https://che.openshift.io v7.10.0 .

Preliminary analysis shows that we have to use editor.worker:
https://github.com/eclipse/che-dashboard/blob/98d3769ab123636dbf935a8e47eb7beecde9d228/src/monaco-env-setup.ts#L36

https://github.com/eclipse/che-dashboard/blob/98d3769ab123636dbf935a8e47eb7beecde9d228/gulp/scripts.js#L96

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. Open any Workspace Details > devfile in UD.
  2. Open a console to find the error.

Expected behavior

The editor.worker should be loaded without any errors.

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Installation method

  • chectl
  • che-operator
  • minishift-addon
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify
@olexii4 olexii4 added the kind/bug Outline of a bug - must adhere to the bug report template. label Apr 1, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Apr 1, 2020
@sleshchenko sleshchenko added area/dashboard severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Apr 2, 2020
@olexii4 olexii4 changed the title Monaco Editor is not working properly in UD Monaco Editor works in main thread instead of web-worker Apr 2, 2020
@olexii4 olexii4 changed the title Monaco Editor works in main thread instead of web-worker Monaco Editor works in the main thread instead of web-worker Apr 2, 2020
@che-bot
Copy link
Contributor

che-bot commented Oct 1, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 1, 2020
@sleshchenko sleshchenko removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 1, 2020
@che-bot
Copy link
Contributor

che-bot commented Apr 6, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 6, 2021
@olexii4 olexii4 removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 8, 2021
@olexii4 olexii4 mentioned this issue Sep 20, 2021
Merged
@sleshchenko sleshchenko added this to the 7.37 milestone Sep 21, 2021
@sleshchenko sleshchenko mentioned this issue Sep 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
7.37
3 participants
@sleshchenko @olexii4 @che-bot