Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a single host version of the happy-path test #16842

Closed
l0rd opened this issue May 4, 2020 · 7 comments
Closed

Implement a single host version of the happy-path test #16842

l0rd opened this issue May 4, 2020 · 7 comments
Labels
area/qe kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@l0rd
Copy link
Contributor

l0rd commented May 4, 2020

Is your task related to a problem? Please describe.

Single host is not currently tested.

Describe the solution you'd like

Implement an happy path tests to address that.

cc @dmytro-ndp @rhopp

@l0rd l0rd added the kind/task Internal things, technical debt, and to-do tasks to be performed. label May 4, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label May 4, 2020
@l0rd
Copy link
Contributor Author

l0rd commented May 4, 2020

That's important considered #16702 and #12914

@l0rd l0rd added area/qe severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels May 4, 2020
@rhopp
Copy link
Contributor

rhopp commented May 6, 2020

@l0rd Should single host already work also for Openshift, or is it still just a k8s (ingress) thing? (Asking to beter understand a scope of this)

Also... If we would have to make a decision which "version" (single vs multi host) should be the "primary" target for our testing - is it safe to assume, that single-host will be the more important (in the near future)?

@l0rd
Copy link
Contributor Author

l0rd commented May 6, 2020

@rhopp it only works on Kubernetes right now. We are working on #16702 and openshift/origin#20474 to have support on OpenShift routes as well.

@l0rd
Copy link
Contributor Author

l0rd commented May 6, 2020

Also... If we would have to make a decision which "version" (single vs multi host) should be the "primary" target for our testing - is it safe to assume, that single-host will be the more important (in the near future)?

Yes

@rhopp
Copy link
Contributor

rhopp commented May 13, 2020

I've created "subtask" for switching k8s based tests/jobs to single-host: #16904

@rhopp rhopp added this to the Backlog - QE milestone Jun 17, 2020
@sparkoo
Copy link
Member

sparkoo commented Sep 4, 2020

as of today, gateway single-host che-server part is merged in master and is in nightly images at quay.io/eclipse/che-server:nightly. We're working on the che-operator. There is "working" testing image quay.io/lkrejci/che-operator:gateway.

to deploy gateway single-host, use this CheCluster patch:

apiVersion: org.eclipse.che/v1
kind: CheCluster
metadata:
  name: eclipse-che
spec:
  server:
    serverExposureStrategy: 'single-host'
    singleHostExposureType: 'gateway'
    customCheProperties:
      CHE_INFRA_KUBERNETES_SINGLEHOST_WORKSPACE_EXPOSURE: 'gateway'

with this chectl command (don't forget to set <platform>):

chectl server:start --installer=operator --platform=<platform> --che-operator-image=quay.io/lkrejci/che-operator:gateway --che-operator-cr-patch-yaml=op.patch

There are these known limitations/WIP:

  • the extra CHE_INFRA_KUBERNETES_SINGLEHOST_WORKSPACE_EXPOSURE property is needed, because we've changed the parameter name in che-server and it is not yet synced in che-operator image (will be managed with singleHostExposureType: 'gateway')
  • devfile/plugin registries and keycloak are still deployed with their own Ingress/Route. (under development)

@artaleks9
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/qe kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants