Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing version pins in package.json / yarn.lock for che-theia builds #17612

Closed
2 of 3 tasks
nickboldt opened this issue Aug 11, 2020 · 0 comments · Fixed by eclipse-che/che-theia#829
Closed
2 of 3 tasks

Missing version pins in package.json / yarn.lock for che-theia builds #17612

nickboldt opened this issue Aug 11, 2020 · 0 comments · Fixed by eclipse-che/che-theia#829
Assignees
@azatsarynnyy
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.18

Comments

@nickboldt
Copy link
Contributor

nickboldt commented Aug 11, 2020 •
edited
Loading

Describe the bug

As found in https://issues.redhat.com/browse/CRW-1149, accidental changes in master are getting into a stable release

Per discussion on Tuesday, the solution could be to enhance the build.sh, yarn.lock and.or package.json files in che-theia repo to ensure that in the stable branches like 7.16.x, we're not pointing to latest / master branch content.

Che version

  • latest
  • nightly
  • other: please specify

Additional context

See also #17613 re: happy path PR checking in che-theia plugin repos.
@nickboldt nickboldt added the kind/bug Outline of a bug - must adhere to the bug report template. label Aug 11, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 11, 2020
@nickboldt nickboldt mentioned this issue Aug 11, 2020
Closed
@benoitf benoitf added area/editor/theia Issues related to the che-theia IDE of Che severity/P1 Has a major impact to usage or development of the system. labels Aug 11, 2020
@azatsarynnyy azatsarynnyy removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 11, 2020
@azatsarynnyy azatsarynnyy mentioned this issue Aug 11, 2020
Closed
11 tasks
@azatsarynnyy azatsarynnyy added this to the 7.18 milestone Aug 11, 2020
@azatsarynnyy azatsarynnyy mentioned this issue Aug 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azatsarynnyy azatsarynnyy

Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.18
Development

Successfully merging a pull request may close this issue.

Pin npm libs versions when releasing eclipse-che/che-theia
4 participants
@nickboldt @benoitf @azatsarynnyy @che-bot