Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factory link support on password protected git repositories #17829

Closed
l0rd opened this issue Sep 10, 2020 · 2 comments
Closed

Factory link support on password protected git repositories #17829

l0rd opened this issue Sep 10, 2020 · 2 comments
Labels
area/factory/dashboard Issues related to factories frontend (che user dashboard side) area/factory/server Server side of factory implementation kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@l0rd
Copy link
Contributor

l0rd commented Sep 10, 2020

Is your enhancement related to a problem? Please describe.

If a git repository contains a devfile and a Che instance is available at https://my-che-sever.com, starting a Che workspace is just a matter of opening a link like the following one:

https://my-che-server.com/f?url=https://my-git-server/my-git-repo/my-devfile.yaml

That works fine if the git server is not password protected. But doesn't work at all if the git server requires authentication to access my-git-repo. Even if the user has setup its git credentials for his Che workspaces.

Describe the solution you'd like

If available we should leverage the user git credentials to get the devfile. Otherwise we should prompt the user for his credentials.

Technically speaking we may work on #15973 first so that the cloning of the git repo (if it hasn't been done yet) happens before the workspace starts and we would be able to get the devfile then.

@l0rd l0rd added the kind/enhancement A feature request - must adhere to the feature request template. label Sep 10, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 10, 2020
@vparfonov vparfonov added severity/P2 Has a minor but important impact to the usage or development of the system. area/factory/dashboard Issues related to factories frontend (che user dashboard side) area/factory/server Server side of factory implementation area/factory/theia and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Sep 14, 2020
@che-bot
Copy link
Contributor

che-bot commented Mar 17, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 17, 2021
@che-bot che-bot closed this as completed Apr 6, 2021
@ericwill
Copy link
Contributor

ericwill commented Apr 6, 2021

This was fixed already in #18494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/factory/dashboard Issues related to factories frontend (che user dashboard side) area/factory/server Server side of factory implementation kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants