Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from ephemeral to persistant workspace lets the database beeing ephemeral #18322

Closed
3 of 5 tasks
MaggusK opened this issue Nov 10, 2020 · 3 comments
Closed
3 of 5 tasks
Labels
area/devfile-registry kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone

Comments

@MaggusK
Copy link

MaggusK commented Nov 10, 2020

Not sure, if this is really a bug, or could be handled as enhancement.
This came out from discussion on: https://mattermost.eclipse.org/eclipse/channels/eclipse-che/kj1j3g5eap8dudpbfo5ceu3tyw

Che version

20.7.1

Expected behavior

If you, for excample, use a sample Devfile in a workspace and you switch from ephemeral mode to persistant mode, the Devfile should be automaticly edited, making the database also persistant.

Runtime

  • Openshift (oc version ??)

Environment

  • my computer
    • Linux
  • Cloud
    • Redhat openshift.io

@ericwill

@MaggusK MaggusK added the kind/bug Outline of a bug - must adhere to the bug report template. label Nov 10, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Nov 10, 2020
@ibuziuk
Copy link
Member

ibuziuk commented Nov 10, 2020

@ericwill looks like all the devfiles from the registry always use ephemeral db which is not persisted between restarts. I believe it would be a nice idea to update the devfiles with dbs to allow persistence by default e.g. - https://github.com/eclipse/che-devfile-registry/blob/master/devfiles/java-mysql/devfile.yaml#L63

@ericwill
Copy link
Contributor

@ericwill looks like all the devfiles from the registry always use ephemeral db which is not persisted between restarts. I believe it would be a nice idea to update the devfiles with dbs to allow persistence by default e.g. - https://github.com/eclipse/che-devfile-registry/blob/master/devfiles/java-mysql/devfile.yaml#L63

Thanks for the investigation, we'll look into it.

@ericwill ericwill added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Nov 10, 2020
@ericwill ericwill mentioned this issue Nov 12, 2020
34 tasks
@ericwill ericwill added this to the 7.23 milestone Nov 18, 2020
@vitaliy-guliy
Copy link
Contributor

We merged a PR that enables database persistence for some devfiles, that was tested on hosted Che.

There is some issues with nodejs-mongo devfile. They are not related to database persistence, but to building the sample project.

The workspace that created from this devfile has persistent storage, which is attached as PVC.
With PVC we cannot build the node/typescript projects because of well known issues with permissions. It's the same problem that blocks us in developing of Che-Theia on hosted Che.

In case of ephemeral workspace, it become possible to build the sample, but the database is not persistent.
But to test the database persistence on persistent workspace, it's always possible to clone the sample to /tmp, which is not persistent, build and launch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-registry kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants