-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify factory resolution process for private Bitbucket repositories #18389
Comments
From the theoretical POW, i would propose the following reactions to the situations which are given in descrition:
Those two looks pretty similar for me and can be covered with single
Rest of the situations does not looks very questionable for me:
clear
clear
Since it's an unrecoverable error (i.e. user cannot fix situation by fixing the request) i would prefer 5xx codes. |
Is your task related to a problem? Please describe.
Implement Factory resolution process for private Bitbucket repositories
Describe the solution you'd like
In case if che server has enough information (it has Bitbucket personal access token as k8s secret #18386 or it has Bitbucket OAuth1 token)
it should return FactoryDto with devfile inside as a result of
/api/factory/resolver
method. The goal of this taskis to clarify:
/api/factory/resolver
if 'OAuth1 token' is not exists/api/factory/resolver
if 'Bitbucket personal access token' is expired/api/factory/resolver
if the git repository is not exists/api/factory/resolver
if the git repository is not available for the current usergit-credentials-secret
andbitbucket-personal-access-token-secret
Describe alternatives you've considered
n/a
Additional context
#18385
The text was updated successfully, but these errors were encountered: