Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved tabbed editor design #1841

Closed
vparfonov opened this issue Jul 18, 2016 · 1 comment
Closed

Improved tabbed editor design #1841

vparfonov opened this issue Jul 18, 2016 · 1 comment
Assignees
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Milestone

Comments

@vparfonov
Copy link
Contributor

vparfonov commented Jul 18, 2016

We have the basics of the functionality of multi editors, but we now have to implement a proper design and user experience.
Here is the design:
multieditor

Focus
Editor who is currently having the cursor is shown with:

  • a layer over the background of the terminal #4A90E2 alpha:8%
  • a 1px height line a the bottom of the editor's tab

New Editor
A new Editor can be invoked by opening a file from the project explorer.
The new editor is opened in the pane that was having the focus previously.
Pane Management
The management of panes is handled by a small button on the right of the tabs in the pane. When this button is clicked, it shows options:

  • Close Pane: it closes the panes and all the associated terminals.
  • Close All Tabs in Pane: it closes all the tabs from the pane, and close the pane.
  • Split Pane Horizontally: it splits the area of the current pane to create another pane into another row (50% of the height of each pane)
  • Split Pane Vertically: it splits the are of the current pane to create another pane into another column (50% of the width of each pane)

There is another way to split the editor, by doing a right click on a file. The options displayed are:

  • Close: it closes the file
  • Close Others: it closes all other opened file from the pane
  • Close All: it closes all files opened in the current pane
  • Split Pane in Two Rows: it splits the area of the current pane to create another pane into another row (50% of the height of each pane)
  • Split Pane in Two Column: it splits the are of the current pane to create another pane into another column (50% of the width of each pane)

When a new pane is created, it always opens the last focused file.
Too much editors in pane
When there are too many editors in the pane, we do the same behavior than the one we have currently for the editor. We reuse the same button which is handling the pane management.
(Sample: 15 terminals opened in a pane, but space to display the tabs allow to display only 10, then we will have the other 5 terminals in the menu)
Attach one or more files to this issue

@vparfonov vparfonov added kind/enhancement A feature request - must adhere to the feature request template. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. team/ide labels Jul 18, 2016
@vparfonov vparfonov mentioned this issue Jul 18, 2016
4 tasks
@bmicklea bmicklea mentioned this issue Aug 29, 2016
89 tasks
@RomanNikitenko RomanNikitenko added status/in-progress This issue has been taken by an engineer and is under active development. and removed status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. labels Sep 5, 2016
@RomanNikitenko RomanNikitenko added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Sep 9, 2016
@slemeur
Copy link
Contributor

slemeur commented Sep 19, 2016

Updated:

  • Close All Tabs in Pane: it closes all the tabs from the pane, and close the pane.

@RomanNikitenko RomanNikitenko removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 7, 2016
@RomanNikitenko RomanNikitenko added this to the 5.0.0-M6 milestone Oct 7, 2016
@bmicklea bmicklea mentioned this issue Oct 28, 2016
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

No branches or pull requests

3 participants