Externailize dependency on operator-sdk so it's not hardcoded in 4 scripts #18419
Labels
area/che-operator
Issues and PRs related to Eclipse Che Kubernetes Operator
kind/enhancement
A feature request - must adhere to the feature request template.
Milestone
Is your enhancement related to a problem? Please describe.
Mykhailo installed operator-sdk 0.17.2, because in https://github.com/eclipse/che-operator/blob/master/olm/update-nightly-bundle.sh#L34 it says that 0.17.x is required and 0.17.2 is the latest.
Then the build failed...
-- https://github.com/eclipse/che-operator/runs/1426532323?check_suite_focus=true
... even though it includes 0.17.2:
https://github.com/eclipse/che-operator/blob/master/.github/workflows/release.yml#L57
... because OTHER scripts explicitly hardcodedly depend on 0.17.1.
and
Describe the solution you'd like
Move the variable
OPERATOR_SDK_VERSION=v0.17.1
into a text file called VERSION or REQUIREMENTS or something.Load that file when running the shell scrupt, and validate installed operator-sdk version using that version so it's consistent across all scripts.
Describe alternatives you've considered
Keep it hardcoded in 3 scripts and 2 go config files, and occasionally break the build if not all files are updated consistently.
Additional context
The text was updated successfully, but these errors were encountered: