Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Che Theia to upstream changes #18456

Closed
2 tasks done
azatsarynnyy opened this issue Nov 25, 2020 · 3 comments · Fixed by eclipse-che/che-theia#930
Closed
2 tasks done

Adapt Che Theia to upstream changes #18456

azatsarynnyy opened this issue Nov 25, 2020 · 3 comments · Fixed by eclipse-che/che-theia#930
Assignees
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@azatsarynnyy
Copy link
Member

azatsarynnyy commented Nov 25, 2020

Is your task related to a problem? Please describe.

There's a WIP PR eclipse-theia/theia#8759 in upstream Theia that will bring the breaking changes related to mini-browser functionality. The /mini-browser Theia endpoint will be served on a dedicated host.
We need to adapt Che Theia to these changes.

Describe the solution you'd like

We need to declare another Che endpoint in Che Theia meta.yaml descriptor for exposing /mini-browser Theia's endpoint.
Like we did it for /webviews endpoint here.
And tell Che Theia to fetch the /mini-browser's content through a dedicated Che endpoint.

Describe alternatives you've considered

Additional context

Sub-tasks

@azatsarynnyy azatsarynnyy added kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. area/editor/theia Issues related to the che-theia IDE of Che labels Nov 25, 2020
@azatsarynnyy azatsarynnyy self-assigned this Nov 25, 2020
@azatsarynnyy azatsarynnyy added this to the 7.23 milestone Nov 25, 2020
@benoitf
Copy link
Contributor

benoitf commented Nov 25, 2020

@azatsarynnyy what about declaring the new endpoint as soon as possible (in meta.yaml of plug-in registry) ?

@azatsarynnyy
Copy link
Member Author

I'm going to open a PR after lunch 😉

@azatsarynnyy
Copy link
Member Author

okay, opened a PR eclipse-che/che-plugin-registry#712
now, going to lunch 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants