Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change config storage paths from /home/theia/home/theia to the corresponding paths #18548

Closed
RomanNikitenko opened this issue Dec 7, 2020 · 2 comments
Closed

Change config storage paths from /home/theia/home/theia to the corresponding paths #18548

RomanNikitenko opened this issue Dec 7, 2020 · 2 comments
Assignees
@RomanNikitenko
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.27

Comments

@RomanNikitenko
Copy link
Member

Is your task related to a problem? Please describe.

There are 3 fields within config storage:

  • hostLogPath
  • hostStoragePath
  • hostGlobalStoragePath

At the moment they are overridden on che-theia side here.

The current state:

  • hostLogPath comes as /home/theia/.theia/logs/20201207T111804/host and then overridden to /home/theia/home/theia/
  • hostStoragePath comes as /home/theia/.theia/workspace-storage/be0a81bfde25dc291c35808bdaf5f836 and then overridden to /home/theia/home/theia/
  • hostGlobalStoragePath comes as /home/theia/.theia/globalStorage and then overridden to /home/theia/home/theia/

So, /home/theia/home/theia is used for config storage paths.

Describe the solution you'd like

I'm going to change the described behavior within eclipse-che/che-theia#778.
Please see more details here

I tested it and with my changes I have the results like:

  • hostLogPath comes as /home/theia/.theia/logs/20201207T103853/host and returns the same - /home/theia/.theia/logs/20201207T103853/host
  • hostStoragePath comes as /home/theia/.theia/workspace-storage/d4f33a13baafd8232351136427795e20 and returns the same - /home/theia/.theia/workspace-storage/d4f33a13baafd8232351136427795e20
  • hostGlobalStoragePath comes as /home/theia/.theia/globalStorage and returns the same - /home/theia/.theia/globalStorage

Please let me know if there are any objectives to keep /home/theia/home/theia as config storage paths and we have good reasons for such behavior.
@RomanNikitenko RomanNikitenko added kind/task Internal things, technical debt, and to-do tasks to be performed. area/plugins labels Dec 7, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Dec 7, 2020
@azatsarynnyy azatsarynnyy added area/editor/theia Issues related to the che-theia IDE of Che severity/P1 Has a major impact to usage or development of the system. and removed area/plugins status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Dec 7, 2020
@azatsarynnyy azatsarynnyy added this to the 7.24 milestone Dec 7, 2020
@azatsarynnyy azatsarynnyy mentioned this issue Dec 7, 2020
Closed
15 tasks
@azatsarynnyy azatsarynnyy added the status/in-progress This issue has been taken by an engineer and is under active development. label Dec 7, 2020
@azatsarynnyy azatsarynnyy mentioned this issue Dec 7, 2020
Closed
1 task
@RomanNikitenko
Copy link
Member Author

@benoitf mentioned (thanks!) that we have the related issue #18056

@azatsarynnyy azatsarynnyy mentioned this issue Dec 9, 2020
Closed
21 tasks
@nickboldt nickboldt modified the milestones: 7.24, 7.25 Jan 8, 2021
@azatsarynnyy azatsarynnyy modified the milestones: 7.25, 7.26 Jan 14, 2021
@azatsarynnyy azatsarynnyy mentioned this issue Jan 20, 2021
Closed
16 tasks
@RomanNikitenko RomanNikitenko mentioned this issue Feb 3, 2021
Merged
15 tasks
@azatsarynnyy azatsarynnyy modified the milestones: 7.26, 7.27 Feb 9, 2021
@RomanNikitenko RomanNikitenko added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Feb 12, 2021
@RomanNikitenko
Copy link
Member Author

I provided the corresponding changes within eclipse-che/che-theia#778, see more details here: eclipse-che/che-theia@3afdab7
Please let me know if it's required to provide the changes in a separate PR.

@RomanNikitenko RomanNikitenko removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Feb 25, 2021
@azatsarynnyy azatsarynnyy mentioned this issue Feb 25, 2021
Closed
10 tasks
@RomanNikitenko RomanNikitenko mentioned this issue Mar 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomanNikitenko RomanNikitenko

Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.27
Development

No branches or pull requests
4 participants
@nickboldt @azatsarynnyy @RomanNikitenko @che-bot