Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generated PRs for plugin registry should remove all but the latest plugins (instead of including multiple copies of machine-exec and theia) #18596

Closed
nickboldt opened this issue Dec 10, 2020 · 3 comments
Closed

generated PRs for plugin registry should remove all but the latest plugins (instead of including multiple copies of machine-exec and theia) #18596

nickboldt opened this issue Dec 10, 2020 · 3 comments
Assignees
@nickboldt @ericwill
Labels
area/ci CI build and releases, PR testing, & whitelabel/productization issues kind/enhancement A feature request - must adhere to the feature request template. kind/release Issue dedicated to a release (content, status, related PR, go/nogo/problem discussion, etc.) severity/P1 Has a major impact to usage or development of the system.
Milestone
7.25

Comments

@nickboldt
Copy link
Contributor

nickboldt commented Dec 10, 2020 •
edited
Loading

Is your enhancement related to a problem? Please describe.

Today, the generated PRs from the plugin registry's make-release.sh script ADD new plugins to the .x and master branches.

Describe the solution you'd like

But since we've decided to keep only a single version (latest), the PRs should:

  • add the new plugins
  • purge the old ones

We can also take this opportunity (once a week for the .z and .0 releases) to purge old plugins that might have crept in accidentally, by scripting the logic that only ONE plugin (the one stored in latest.txt) should be kept.

Describe alternatives you've considered

Additional context
@nickboldt nickboldt added the kind/enhancement A feature request - must adhere to the feature request template. label Dec 10, 2020
@nickboldt nickboldt self-assigned this Dec 10, 2020
@nickboldt nickboldt added area/ci CI build and releases, PR testing, & whitelabel/productization issues area/productization kind/release Issue dedicated to a release (content, status, related PR, go/nogo/problem discussion, etc.) severity/P1 Has a major impact to usage or development of the system. labels Dec 10, 2020
@nickboldt nickboldt mentioned this issue Dec 10, 2020
Merged
@nickboldt nickboldt changed the title generated PRs for plugin registry should remove all but the latest plugins (instead of multiple copies of machine-exec and theia) generated PRs for plugin registry should remove all but the latest plugins (instead of including multiple copies of machine-exec and theia) Dec 10, 2020
@nickboldt nickboldt mentioned this issue Dec 10, 2020
Closed
11 tasks
@benoitf
Copy link
Contributor

benoitf commented Dec 10, 2020

If we're fast on implementing meta.yaml generation from che-editors file it'll just be a matter of updating che-editors.yaml

@nickboldt
Copy link
Contributor Author

nickboldt commented Dec 23, 2020 •
edited
Loading

I'm guessing this has slipped to 7.25

@nickboldt nickboldt added this to the 7.25 milestone Dec 23, 2020
@nickboldt
Copy link
Contributor Author

slipped to 7.25, and done thanks to @ericwill

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickboldt nickboldt

@ericwill ericwill

Labels
area/ci CI build and releases, PR testing, & whitelabel/productization issues kind/enhancement A feature request - must adhere to the feature request template. kind/release Issue dedicated to a release (content, status, related PR, go/nogo/problem discussion, etc.) severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.25
Development

No branches or pull requests
3 participants
@nickboldt @benoitf @ericwill