Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard should show Che-Theia plugins if the editors is Theia only #18667

Closed
l0rd opened this issue Dec 18, 2020 · 4 comments
Closed

Dashboard should show Che-Theia plugins if the editors is Theia only #18667

l0rd opened this issue Dec 18, 2020 · 4 comments
Labels
area/dashboard area/devfile-spec Issues related to Devfile v2 area/plugins engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template.

Comments

@l0rd
Copy link
Contributor

l0rd commented Dec 18, 2020

Is your enhancement related to a problem? Please describe.

Most of the Che plugins published in the registry are not Che plugins: they can only be used with one specific editor: Theia.

The Dashboard shows Theia plugins as if they were Che plugins.

Describe the solution you'd like

Don’t show Che Theia plugins among Che Plugins in Che dashboard

Additional context

This work should be included in the context of che workspaces that use the DevWorkspace operator, so that's not for v1 devfiles/plugins.

@l0rd l0rd added kind/enhancement A feature request - must adhere to the feature request template. kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. labels Dec 18, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Dec 18, 2020
@yhontyk yhontyk added area/plugins area/dashboard severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Dec 18, 2020
@l0rd l0rd removed the severity/P2 Has a minor but important impact to the usage or development of the system. label Dec 20, 2020
@ericwill
Copy link
Contributor

ericwill commented Jan 4, 2021

I believe we've partially solved this based on how the plugins are defined in the registry:

  • che-theia plugins go in che-theia-plugins.yaml
  • Che editors go in che-editors.yaml
  • All other components go in che-components.yaml

@tsmaeder
Copy link
Contributor

It's not quite clear what a "che-plugin" is. What are the criteria? What do they consist of?

@benoitf
Copy link
Contributor

benoitf commented Jan 26, 2021

@tsmaeder to make it simple, a Che Plugin is not tied to an editor and is not an editor itself

@l0rd l0rd changed the title Distinguish Theia and Che plugins Dashboard should show Che-Theia plugins if the editors is Theia only Mar 26, 2021
@l0rd l0rd removed the kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. label Mar 26, 2021
@l0rd l0rd added this to the DevWorkspace Integration - STEP2 milestone Mar 26, 2021
@l0rd l0rd added area/devfile-spec Issues related to Devfile v2 engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. labels Mar 26, 2021
@l0rd l0rd removed this from the DevWorkspace Integration - STEP3 milestone Oct 4, 2021
@l0rd
Copy link
Contributor Author

l0rd commented Oct 4, 2021

With the transition to DevWorkspace Operator we are not showing editors plugins in the dashboard anymore. Those need to be managed from the editor itself. Closing this issue.

@l0rd l0rd closed this as completed Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard area/devfile-spec Issues related to Devfile v2 area/plugins engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

No branches or pull requests

6 participants