Ability to mount more than one Git credential secret

[mshaposhnik]

Is your task related to a problem? Please describe.

Right now, having Git credential secret in form:

apiVersion: v1
kind: Secret
metadata:
  name: git-credentials-secret
  labels:
    app.kubernetes.io/part-of: che.eclipse.org
    app.kubernetes.io/component: workspace-secret
  annotations:
    che.eclipse.org/automount-workspace-secret: 'true'
    che.eclipse.org/mount-path: /home/theia/.git-credentials
    che.eclipse.org/mount-as: file
    che.eclipse.org/git-credential: 'true'
data:
  credentials: <https://user:pass@example.com in Base64 > 

will result in file mount to each container:

/home/theia/.git-credentials/credentials

https://user:pass@example.com

But if we want to have more than one credential secret, for example, one for GitHub and one for Bitbucket,
secret provisioner will fail. We need to fix that situation.

Describe the solution you'd like

Right now we're not managing content of the files, we just creating volume mount poining to the secret, which will be mount as file on FS by Kubernetes.
So GitCredentialStorageFileSecretApplier should be reworked and allow multiple secrets to be merged into single credential file which will lools like:

/home/theia/.git-credentials/credentials

https://user:pass@server1.com
https://user:pass@server2.com
... etc

Describe alternatives you've considered

Additional context

[l0rd]

This is important but can you please think about the implementation in the context of Che using DevWorkspace operator?

[skabashnyuk]

This is important but can you please think about the implementation in the context of Che using DevWorkspace operator?

Most likely that would be two separate things. One for DevWorkspace operator and the other for Che-server. As I understand the idea is to merge existed multiple git-credentials-secret s during workspace startup in one thing.

[l0rd]

The idea is not to implement it twice. Let's plan that for DevWorkspace only.

[che-bot]

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

[l0rd]

/remove-lifecycle stale