Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent release jobs for same project from executing in parallel #18925

Closed
mkuznyetsov opened this issue Jan 29, 2021 · 1 comment
Closed

Prevent release jobs for same project from executing in parallel #18925

mkuznyetsov opened this issue Jan 29, 2021 · 1 comment
Assignees
Labels
area/ci CI build and releases, PR testing, & whitelabel/productization issues kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.

Comments

@mkuznyetsov
Copy link
Contributor

mkuznyetsov commented Jan 29, 2021

Is your task related to a problem? Please describe.

During release of 7.25.0 Che operator, it was discovered that release job was activated twice at the same time (possibly due to some ). This resulted in a conflict, when while 1 job has failed and the other succeeded, they both managed to overwrite things like pushing different images & olm files to Quay, and this making the images digests referenced in CSVs to be inconsistent with actual images on Quay.

Describe the solution you'd like

To avoid this, we should restrict the execution of release workflows to a max of 1 at a time. If the job gets triggered again, it has to be auto cancelled, or ensure it doesn't start until the previous run has finished (similarly to Centos CI flow). Most likely, we should use already existing GitHub action.

Describe alternatives you've considered

Additional context

As the best options found so far are 3rd party GH extensions, we need to contact emo@eclipse.org to find out about CQ process for vetting 3rd party runs-with dependencies.

This item is on old until we hear back from Wayne Beaton about this topic.

@mkuznyetsov mkuznyetsov added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Jan 29, 2021
@mkuznyetsov mkuznyetsov self-assigned this Jan 29, 2021
@mkuznyetsov mkuznyetsov added the area/ci CI build and releases, PR testing, & whitelabel/productization issues label Jan 29, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 29, 2021
@mkuznyetsov mkuznyetsov mentioned this issue Feb 1, 2021
16 tasks
@ScrewTSW ScrewTSW added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Feb 1, 2021
@mkuznyetsov
Copy link
Contributor Author

fkirc/skip-duplicate-actions works for our intended purpose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI build and releases, PR testing, & whitelabel/productization issues kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

3 participants