Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSH plugin failed to upload ssh key to GitHub #18952

Closed
2 tasks done
vitaliy-guliy opened this issue Feb 2, 2021 · 3 comments
Closed
2 tasks done

SSH plugin failed to upload ssh key to GitHub #18952

vitaliy-guliy opened this issue Feb 2, 2021 · 3 comments
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.

Comments

@vitaliy-guliy
Copy link
Contributor

vitaliy-guliy commented Feb 2, 2021 •
edited
Loading

Describe the bug

SSH plugin proposes to upload a new key to GitHub in case the user is cloning a repository via SSH.
This feature is not working anymore since the oauth authentication failed.

Screenshot from 2021-02-02 19-03-51

It's hard to notice, but after clicking 'Upload' button the oauth popup opens for a while, but then immediately hides with this error in theia console

2021-02-02 16:46:38.723 root ERROR Request getOAuthToken failed with error: Failed access: http://keycloak.eclipse-che.svc:8080/auth/realms/che/broker/github/token?token, method: GET, response code: 502, message: <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"  "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" class="">

<head>
    <meta charset="utf-8">
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
    <meta name="robots" content="noindex, nofollow">

    <title>Log in to Eclipse Che</title>
    <link rel="icon" href="/auth/resources/6.0.1/login/che/img/favicon.ico" />
            <link href="/auth/resources/6.0.1/login/che/css/che-login.css" rel="stylesheet" />
</head>

<body class="">
  <div class="">
    <div id="kc-header" class="">
      <div id="kc-header-wrapper" class="">Eclipse Che</div>
    </div>
    <div class=" ">
      <header class="">
        <h1 id="kc-page-title">        We&#39;re sorry...
</h1>
      </header>
      <div id="kc-content">
        <div id="kc-content-wrapper">


        <div id="kc-error-message">
            <p class="instruction">Could not obtain token from identity provider.</p>
        </div>

        </div>
      </div>

    </div>
  </div>
</body>
</html>

Tested on multiuser Che running in local minikube.

Required for #13494

Che version

  • latest

Steps to reproduce

Runtime

  • minikube (include output of minikube version and kubectl version)

Screenshots
@vitaliy-guliy vitaliy-guliy added kind/bug Outline of a bug - must adhere to the bug report template. team/plugins area/plugins labels Feb 2, 2021
@mshaposhnik mshaposhnik added the severity/P1 Has a major impact to usage or development of the system. label Feb 2, 2021
@vitaliy-guliy
Copy link
Contributor Author

On hosted Che I have

2021-02-03 09:28:12.031 root ERROR Request getOAuthToken failed with error: "401" returned by "/oauth/token?oauth_provider=github"." Params:

@vinokurig
Copy link
Contributor

On hosted Che I have

2021-02-03 09:28:12.031 root ERROR Request getOAuthToken failed with error: "401" returned by "/oauth/token?oauth_provider=github"." Params:

I think it will be fixed by eclipse-che/che-theia#969

@vitaliy-guliy
Copy link
Contributor Author

The issue is mostly related for the local Che. Adding of the key works fine when the keycloak is properly configured.
I'm close this issue as not relevant anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mshaposhnik @vitaliy-guliy @vinokurig