Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UD] preferred_type is not respected by dashboard #19069

Closed
3 tasks
sleshchenko opened this issue Feb 15, 2021 · 2 comments
Closed
3 tasks

[UD] preferred_type is not respected by dashboard #19069

sleshchenko opened this issue Feb 15, 2021 · 2 comments
Assignees
Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. sprint/current
Milestone

Comments

@sleshchenko
Copy link
Member

Describe the bug

[UD] preferred_type is not respected by dashboad

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. Deploy che with non-default storage type as preferred:
chectl server:deploy --installer=operator --platform=openshift --che-operator-cr-patch-yaml=/home/sleshche/che-custom-che-server.yaml
spec:
  server:
    cheImagePullPolicy: Always
    customCheProperties:
      CHE_WORKSPACE_STORAGE_AVAILABLE__TYPES: persistent,ephemeral,async
      CHE_WORKSPACE_STORAGE_PREFERRED__TYPE: ephemeral
  1. Check that it's used on Get Started
    Screenshot_20210215_142852

  2. Check that it's used on Create Custom Workspace
    Screenshot_20210215_142903

  3. Create that it's used on Factory flow
    Screenshot_20210215_143120

@sleshchenko sleshchenko added kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. area/dashboard labels Feb 15, 2021
@sleshchenko sleshchenko added this to the 7.28 milestone Mar 9, 2021
@sleshchenko sleshchenko changed the title [UD] preferred_type is not respected by dashboad [UD] preferred_type is not respected by dashboard Mar 9, 2021
@olexii4 olexii4 self-assigned this Mar 10, 2021
@sleshchenko sleshchenko modified the milestones: 7.28, 7.29 Mar 18, 2021
@sleshchenko
Copy link
Member Author

Get started page will be fixed in 7.28.
Not timeline for other cases yet

@sleshchenko
Copy link
Member Author

tested and after eclipse-che/che-dashboard#187 all of the described scenarios work as expected - preferable type is applied:

  • for factory flow - only when devfile does not have specified storage attributes
  • for create custom workspace(templates + load devfile) - always, storage attributes are always overridden. A dedicated issue will be created to make custom workspace page respect devfile storage attributes, and apply default only when they are missing.

@sleshchenko sleshchenko added this to the 7.28 milestone Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. sprint/current
Projects
None yet
Development

No branches or pull requests

2 participants