Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to devfile v2 factory flow support #19147

Closed
sleshchenko opened this issue Feb 25, 2021 · 2 comments · Fixed by eclipse-che/che-dashboard#175
Closed

Improvements to devfile v2 factory flow support #19147

sleshchenko opened this issue Feb 25, 2021 · 2 comments · Fixed by eclipse-che/che-dashboard#175
Labels
area/dashboard engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template.
Milestone

Comments

@sleshchenko
Copy link
Member

Is your enhancement related to a problem? Please describe.

eclipse-che/che-dashboard#175 partially implements factory flow, but some places should be improved, reworked:

  1. Namespace should be created if it does not exist.
  2. Specify the routing class che.
  3. Default editors and plugins should be propagated to the DevWorkspace CR namespace, we should not rely on the DevWorkspaceTemplate registry, like we have after PR
    - name: theia-next
      plugin:
        kubernetes:
          name: theia-next
          namespace: devworkspace-plugins
    - name: machine-exec
      plugin:
        kubernetes:
          name: machine-exec
          namespace: devworkspace-plugins
@sleshchenko sleshchenko added kind/enhancement A feature request - must adhere to the feature request template. area/dashboard engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. labels Feb 25, 2021
@l0rd l0rd changed the title Support factory flow for devfile v2 Improvements to devfile v2 factory flow support Mar 3, 2021
@l0rd l0rd removed this from the DevWorkspace Integration - STEP1 milestone Mar 3, 2021
@l0rd
Copy link
Contributor

l0rd commented Mar 3, 2021

I am removing this issue from milestone 1 as we only tracking epics in that milestone.

@sleshchenko sleshchenko added this to the 7.28 milestone Mar 5, 2021
@sleshchenko
Copy link
Member Author

is implemented in eclipse-che/che-dashboard#175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants