Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align TaskScope with VS Code API #19338

Closed
RomanNikitenko opened this issue Mar 19, 2021 · 2 comments
Closed

Align TaskScope with VS Code API #19338

RomanNikitenko opened this issue Mar 19, 2021 · 2 comments
Assignees
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code.

Comments

@RomanNikitenko
Copy link
Member

RomanNikitenko commented Mar 19, 2021

Is your task related to a problem? Please describe.

At the moment the following TaskScope enum is used on che-theia side:

export enum TaskScope {
        Global = 0,
        Workspace = 1
}

The corresponding VS Code enum is:

export enum TaskScope {
	Global = 1,
	Workspace = 2
}

Theia has the difference as well, but it's going to be changed on theia side soon.

Describe the solution you'd like

I believe we should align the enum with VS Code API ASAP to avoid conflicts.

Describe alternatives you've considered

I don't see an alternative.

Additional context

AFAIK the following plugins are affected:

  • workspace-pugin
  • containers-plugin
  • task-plugin

and eclipse-che-theia-plugin extension

@RomanNikitenko RomanNikitenko added kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. area/plugins severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. and removed severity/P1 Has a major impact to usage or development of the system. labels Mar 19, 2021
@RomanNikitenko
Copy link
Member Author

RomanNikitenko commented Mar 19, 2021

The corresponding PR in upstream was merged, locally at building images I got the following:

tasks_scope_errors

The same errors: https://codeready-workspaces-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/Che-Theia-PR-check-E2E-Happy-path-tests-against-K8S__reserved/2611/console

@benoitf
Copy link
Contributor

benoitf commented Mar 19, 2021

thanks for the fix 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code.
Projects
None yet
Development

No branches or pull requests

2 participants